[GitHub] [ozone] sodonnel commented on a change in pull request #2549: HDDS-5604. Intermittent failure in TestPipelineClose.

[GitBox <gi...@apache.org>]

sodonnel commented on a change in pull request #2549:
URL: https://github.com/apache/ozone/pull/2549#discussion_r691045990



##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestPipelineClose.java
##########
@@ -242,7 +238,7 @@ public void testPipelineCloseWithLogFailure() throws IOException {
     xceiverRatis.handleNodeLogFailure(groupId, null);
 
     // verify SCM receives a pipeline action report "immediately"
-    Mockito.verify(pipelineActionTest, Mockito.timeout(100))
+    Mockito.verify(pipelineActionTest, Mockito.timeout(500))

Review comment:
       If it is still failing, I wonder does the timeout need to be even higher. In the init() method of this test class, I see:
   
   ```
     public void init() throws Exception {
       conf = new OzoneConfiguration();
       cluster = MiniOzoneCluster.newBuilder(conf).setNumDatanodes(3).build();
       conf.setTimeDuration(HddsConfigKeys.HDDS_HEARTBEAT_INTERVAL, 1000,
           TimeUnit.MILLISECONDS);
       pipelineDestroyTimeoutInMillis = 1000;
       conf.setTimeDuration(ScmConfigKeys.OZONE_SCM_PIPELINE_DESTROY_TIMEOUT,
           pipelineDestroyTimeoutInMillis, TimeUnit.MILLISECONDS);
      ...
   ```
   
   Should the conf not be set before the MiniOzoneCluster.build() method is called? Could the cluster potentially start without the conf changes?
   
   
   I cannot remember how this works. The DNs need to send a command to SCM that the pipeline should be closed here - does the DN do that over the DN heartbeat, or via some other mechanism? If the heartbeat is set to 1 second, then could this message take just over a second to arrive in the worse case?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org