You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/12/14 16:28:10 UTC

[kudu-CR] [Java] Upgrade dependencies 

Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16874


Change subject: [Java] Upgrade dependencies
......................................................................

[Java] Upgrade dependencies

Upgrades the Java dependencies and Gradle versions.

Major version upgrades:
- guava 29.0-jre -> 30.0-jre
- scopt 3.7.1 -> 4.0.0

Minor version upgrades:
- jmh 1.26 -> 1.27
- log4j 2.13.3 -> 2.14.0
- micrometer 1.5.5 -> 1.6.2
- mockito 3.5.13 -> 3.6.28
- protobuf 3.13.0 -> 3.14.0
- yetus 0.12.0 -> 0.13.0

Maintenance version upgrades:
- jetty 9.4.32.v20200930 -> 9.4.35.v20201120
- netty 4.1.52.Final -> 4.1.55.Final
- scalatest 3.2.2 -> 3.2.3

Gradle upgrades:
- gradle 6.6.1 -> 6.7.1
- gradle-versions-plugin 0.33.0 -> 0.36.0
- gradle-protobuf-plugin 0.8.13 -> 0.8.14
- nebula-clojure-plugin 9.4.1 -> 9.4.2
- spotbugs-gradle-plugin 4.5.0 -> 4.6.0
- gradle-error-prone-plugin 1.2.1 -> 1.3.0
- gradle-animal-sniffer-plugin 1.5.1 -> 1.5.2
- jmh-gradle-plugin 0.5.1 -> 0.5.2

Change-Id: Ib4b319a67f629bcb60ae54187cee1c3257d6e1a2
---
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestOptions.scala
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java
4 files changed, 26 insertions(+), 25 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/16874/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib4b319a67f629bcb60ae54187cee1c3257d6e1a2
Gerrit-Change-Number: 16874
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>

[kudu-CR] [Java] Upgrade dependencies

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16874 )

Change subject: [Java] Upgrade dependencies
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16874/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java:

http://gerrit.cloudera.org:8080/#/c/16874/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java@425
PS1, Line 425: an 
nit: drop



-- 
To view, visit http://gerrit.cloudera.org:8080/16874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4b319a67f629bcb60ae54187cee1c3257d6e1a2
Gerrit-Change-Number: 16874
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 18 Dec 2020 01:05:02 +0000
Gerrit-HasComments: Yes

[kudu-CR] [Java] Upgrade dependencies

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16874

to look at the new patch set (#3).

Change subject: [Java] Upgrade dependencies
......................................................................

[Java] Upgrade dependencies

Upgrades the Java dependencies and Gradle versions.

Major version upgrades:
- guava 29.0-jre -> 30.1-jre
- scopt 3.7.1 -> 4.0.0

Minor version upgrades:
- jmh 1.26 -> 1.27
- log4j 2.13.3 -> 2.14.0
- micrometer 1.5.5 -> 1.6.2
- mockito 3.5.13 -> 3.6.28
- protobuf 3.13.0 -> 3.14.0
- yetus 0.12.0 -> 0.13.0

Maintenance version upgrades:
- jetty 9.4.32.v20200930 -> 9.4.35.v20201120
- netty 4.1.52.Final -> 4.1.56.Final
- scalatest 3.2.2 -> 3.2.3

Gradle upgrades:
- gradle 6.6.1 -> 6.7.1
- gradle-versions-plugin 0.33.0 -> 0.36.0
- gradle-protobuf-plugin 0.8.13 -> 0.8.14
- nebula-clojure-plugin 9.4.1 -> 9.4.2
- spotbugs-gradle-plugin 4.5.0 -> 4.6.0
- gradle-error-prone-plugin 1.2.1 -> 1.3.0
- gradle-animal-sniffer-plugin 1.5.1 -> 1.5.2
- jmh-gradle-plugin 0.5.1 -> 0.5.2

Change-Id: Ib4b319a67f629bcb60ae54187cee1c3257d6e1a2
---
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
M java/gradle/wrapper/gradle-wrapper.properties
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestOptions.scala
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java
5 files changed, 27 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/16874/3
-- 
To view, visit http://gerrit.cloudera.org:8080/16874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib4b319a67f629bcb60ae54187cee1c3257d6e1a2
Gerrit-Change-Number: 16874
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [Java] Upgrade dependencies

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16874 )

Change subject: [Java] Upgrade dependencies
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4b319a67f629bcb60ae54187cee1c3257d6e1a2
Gerrit-Change-Number: 16874
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 04 Jan 2021 18:54:32 +0000
Gerrit-HasComments: No

[kudu-CR] [Java] Upgrade dependencies

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16874 )

Change subject: [Java] Upgrade dependencies
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4b319a67f629bcb60ae54187cee1c3257d6e1a2
Gerrit-Change-Number: 16874
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 04 Jan 2021 14:31:02 +0000
Gerrit-HasComments: No

[kudu-CR] [Java] Upgrade dependencies

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16874

to look at the new patch set (#2).

Change subject: [Java] Upgrade dependencies
......................................................................

[Java] Upgrade dependencies

Upgrades the Java dependencies and Gradle versions.

Major version upgrades:
- guava 29.0-jre -> 30.1-jre
- scopt 3.7.1 -> 4.0.0

Minor version upgrades:
- jmh 1.26 -> 1.27
- log4j 2.13.3 -> 2.14.0
- micrometer 1.5.5 -> 1.6.2
- mockito 3.5.13 -> 3.6.28
- protobuf 3.13.0 -> 3.14.0
- yetus 0.12.0 -> 0.13.0

Maintenance version upgrades:
- jetty 9.4.32.v20200930 -> 9.4.35.v20201120
- netty 4.1.52.Final -> 4.1.56.Final
- scalatest 3.2.2 -> 3.2.3

Gradle upgrades:
- gradle 6.6.1 -> 6.7.1
- gradle-versions-plugin 0.33.0 -> 0.36.0
- gradle-protobuf-plugin 0.8.13 -> 0.8.14
- nebula-clojure-plugin 9.4.1 -> 9.4.2
- spotbugs-gradle-plugin 4.5.0 -> 4.6.0
- gradle-error-prone-plugin 1.2.1 -> 1.3.0
- gradle-animal-sniffer-plugin 1.5.1 -> 1.5.2
- jmh-gradle-plugin 0.5.1 -> 0.5.2

Change-Id: Ib4b319a67f629bcb60ae54187cee1c3257d6e1a2
---
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestOptions.scala
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java
4 files changed, 26 insertions(+), 25 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/16874/2
-- 
To view, visit http://gerrit.cloudera.org:8080/16874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib4b319a67f629bcb60ae54187cee1c3257d6e1a2
Gerrit-Change-Number: 16874
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [Java] Upgrade dependencies

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16874 )

Change subject: [Java] Upgrade dependencies
......................................................................


Patch Set 2:

maybe we should upgrade the Gradle wrapper to 6.7.1 as well?


-- 
To view, visit http://gerrit.cloudera.org:8080/16874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4b319a67f629bcb60ae54187cee1c3257d6e1a2
Gerrit-Change-Number: 16874
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 05 Jan 2021 15:19:21 +0000
Gerrit-HasComments: No

[kudu-CR] [Java] Upgrade dependencies

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16874 )

Change subject: [Java] Upgrade dependencies
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16874/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java:

http://gerrit.cloudera.org:8080/#/c/16874/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java@427
PS2, Line 427:     while (((ByteBuf) embedder.outboundMessages().peek()).readableBytes() == 0) {
             :       embedder.readOutbound();
             :     }
Just curious: is this change due to the fact that with the newer version of some related packages now there are multiple empty messages, while with prior versions there could be at most one empty message?



-- 
To view, visit http://gerrit.cloudera.org:8080/16874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4b319a67f629bcb60ae54187cee1c3257d6e1a2
Gerrit-Change-Number: 16874
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 04 Jan 2021 22:44:33 +0000
Gerrit-HasComments: Yes

[kudu-CR] [Java] Upgrade dependencies

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16874 )

Change subject: [Java] Upgrade dependencies
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4b319a67f629bcb60ae54187cee1c3257d6e1a2
Gerrit-Change-Number: 16874
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 05 Jan 2021 15:33:27 +0000
Gerrit-HasComments: No

[kudu-CR] [Java] Upgrade dependencies

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16874 )

Change subject: [Java] Upgrade dependencies
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16874/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java:

http://gerrit.cloudera.org:8080/#/c/16874/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java@425
PS1, Line 425: an 
> nit: drop
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/16874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4b319a67f629bcb60ae54187cee1c3257d6e1a2
Gerrit-Change-Number: 16874
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 04 Jan 2021 18:38:04 +0000
Gerrit-HasComments: Yes

[kudu-CR] [Java] Upgrade dependencies

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16874 )

Change subject: [Java] Upgrade dependencies
......................................................................

[Java] Upgrade dependencies

Upgrades the Java dependencies and Gradle versions.

Major version upgrades:
- guava 29.0-jre -> 30.1-jre
- scopt 3.7.1 -> 4.0.0

Minor version upgrades:
- jmh 1.26 -> 1.27
- log4j 2.13.3 -> 2.14.0
- micrometer 1.5.5 -> 1.6.2
- mockito 3.5.13 -> 3.6.28
- protobuf 3.13.0 -> 3.14.0
- yetus 0.12.0 -> 0.13.0

Maintenance version upgrades:
- jetty 9.4.32.v20200930 -> 9.4.35.v20201120
- netty 4.1.52.Final -> 4.1.56.Final
- scalatest 3.2.2 -> 3.2.3

Gradle upgrades:
- gradle 6.6.1 -> 6.7.1
- gradle-versions-plugin 0.33.0 -> 0.36.0
- gradle-protobuf-plugin 0.8.13 -> 0.8.14
- nebula-clojure-plugin 9.4.1 -> 9.4.2
- spotbugs-gradle-plugin 4.5.0 -> 4.6.0
- gradle-error-prone-plugin 1.2.1 -> 1.3.0
- gradle-animal-sniffer-plugin 1.5.1 -> 1.5.2
- jmh-gradle-plugin 0.5.1 -> 0.5.2

Change-Id: Ib4b319a67f629bcb60ae54187cee1c3257d6e1a2
Reviewed-on: http://gerrit.cloudera.org:8080/16874
Reviewed-by: Attila Bukor <ab...@apache.org>
Tested-by: Kudu Jenkins
---
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
M java/gradle/wrapper/gradle-wrapper.properties
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestOptions.scala
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java
5 files changed, 27 insertions(+), 26 deletions(-)

Approvals:
  Attila Bukor: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/16874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4b319a67f629bcb60ae54187cee1c3257d6e1a2
Gerrit-Change-Number: 16874
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)