You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by JPercivall <gi...@git.apache.org> on 2017/03/22 03:10:12 UTC

[GitHub] nifi pull request #1610: NIFI-3633 Adding HttpNotificationService.

GitHub user JPercivall opened a pull request:

    https://github.com/apache/nifi/pull/1610

    NIFI-3633 Adding HttpNotificationService.

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [X] Have you written or updated unit tests to verify your changes?
    - [X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [X] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [X] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [X] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [X] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JPercivall/nifi NIFI-3633

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1610.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1610
    
----
commit 4e5b0a5bd3b7872f0058033e34971ab6bae97c93
Author: Joe Percivall <jp...@apache.org>
Date:   2017-03-22T02:50:06Z

    NIFI-3633 Adding HttpNotificationService.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1610: NIFI-3633 Adding HttpNotificationService.

Posted by joewitt <gi...@git.apache.org>.

Github user joewitt commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1610#discussion_r110472232
  
    --- Diff: nifi-bootstrap/pom.xml ---
    @@ -34,13 +34,26 @@ language governing permissions and limitations under the License. -->
                 <artifactId>nifi-utils</artifactId>
             </dependency>
             <dependency>
    +            <groupId>org.apache.nifi</groupId>
    +            <artifactId>nifi-security-utils</artifactId>
    +        </dependency>
    +        <dependency>
                 <groupId>javax.mail</groupId>
                 <artifactId>mail</artifactId>
             </dependency>
             <dependency>
                 <groupId>org.apache.nifi</groupId>
                 <artifactId>nifi-expression-language</artifactId>
             </dependency>
    +        <dependency>
    +            <groupId>com.squareup.okhttp3</groupId>
    --- End diff --
    
    I checked the licensing and indeed it is apache with no claimed copyrights and no declared notices.  Good.  However, there are several dependencies.  Did you verify none of them require any updates to our license/notices for the convenience binary/assembly?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1610: NIFI-3633 Adding HttpNotificationService.

Posted by joewitt <gi...@git.apache.org>.

Github user joewitt commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1610#discussion_r110471840
  
    --- Diff: nifi-bootstrap/pom.xml ---
    @@ -34,13 +34,26 @@ language governing permissions and limitations under the License. -->
                 <artifactId>nifi-utils</artifactId>
             </dependency>
             <dependency>
    +            <groupId>org.apache.nifi</groupId>
    +            <artifactId>nifi-security-utils</artifactId>
    +        </dependency>
    +        <dependency>
                 <groupId>javax.mail</groupId>
                 <artifactId>mail</artifactId>
             </dependency>
             <dependency>
                 <groupId>org.apache.nifi</groupId>
                 <artifactId>nifi-expression-language</artifactId>
             </dependency>
    +        <dependency>
    +            <groupId>com.squareup.okhttp3</groupId>
    +            <artifactId>okhttp</artifactId>
    --- End diff --
    
    by pulling this dependency in here you'll also need to handle the dependency properly in the rpm assembly.  Otherwise when the RPM is built it wont work.  True for any transitive deps of this as well and this dependency has many of them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1610: NIFI-3633 Adding HttpNotificationService.

Posted by joewitt <gi...@git.apache.org>.

Github user joewitt commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1610#discussion_r110471797
  
    --- Diff: nifi-bootstrap/pom.xml ---
    @@ -34,13 +34,26 @@ language governing permissions and limitations under the License. -->
                 <artifactId>nifi-utils</artifactId>
             </dependency>
             <dependency>
    +            <groupId>org.apache.nifi</groupId>
    --- End diff --
    
    by pulling this dependency in here you'll also need to handle the dependency properly in the rpm assembly.  Otherwise when the RPM is built it wont work.  True for any transitive deps of this as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1610: NIFI-3633 Adding HttpNotificationService.

Posted by joewitt <gi...@git.apache.org>.

Github user joewitt commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1610#discussion_r110472437
  
    --- Diff: nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/NotificationServiceManager.java ---
    @@ -420,15 +424,15 @@ public static Element getChild(final Element element, final String tagName) {
         }
     
         private static class ConfiguredNotificationService {
    -        private final NotificationService service;
    +        private final AbstractNotificationService service;
             private final Map<String, String> properties;
     
    -        public ConfiguredNotificationService(final NotificationService service, final Map<String, String> properties) {
    +        public ConfiguredNotificationService(final AbstractNotificationService service, final Map<String, String> properties) {
    --- End diff --
    
    why go from the interface to the abstract implementation here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---