You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Prasanna Santhanam <ts...@apache.org> on 2013/10/15 14:10:25 UTC

Re: Review Request 14648: Added few changes related to 4870

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14648/
-----------------------------------------------------------

(Updated Oct. 15, 2013, 12:10 p.m.)


Review request for cloudstack and Prasanna Santhanam.


Changes
-------

include cloudstack group


Repository: cloudstack-git


Description
-------

Added few naming convention changes--minor.


Diffs
-----

  tools/marvin/marvin/deployDataCenter.py beed8c8 

Diff: https://reviews.apache.org/r/14648/diff/


Testing
-------


Thanks,

Santhosh Edukulla

Re: Review Request 14648: Added few changes related to 4870

Posted by Santhosh Edukulla <sa...@citrix.com>.


> On Oct. 22, 2013, 6:37 a.m., Prasanna Santhanam wrote:
> > This looks fine except pep8 is broken in a few places. Can you please run pep8 *.py in tools/marvin/marvin to ensure the formatting is maintained? Please upload the patch that corrects these issues.

The changes for this went in with patch# d4072c6 - master.  


- Santhosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14648/#review27279
-----------------------------------------------------------


On Oct. 15, 2013, 12:10 p.m., Santhosh Edukulla wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14648/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2013, 12:10 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added few naming convention changes--minor.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/deployDataCenter.py beed8c8 
> 
> Diff: https://reviews.apache.org/r/14648/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 14648: Added few changes related to 4870

Posted by Prasanna Santhanam <ts...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14648/#review27279
-----------------------------------------------------------


This looks fine except pep8 is broken in a few places. Can you please run pep8 *.py in tools/marvin/marvin to ensure the formatting is maintained? Please upload the patch that corrects these issues.

- Prasanna Santhanam


On Oct. 15, 2013, 12:10 p.m., Santhosh Edukulla wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14648/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2013, 12:10 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added few naming convention changes--minor.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/deployDataCenter.py beed8c8 
> 
> Diff: https://reviews.apache.org/r/14648/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 14648: Added few changes related to 4870

Posted by Girish Shilamkar <gi...@clogeny.com>.


> On Nov. 8, 2013, 9:15 a.m., Girish Shilamkar wrote:
> > 4.2: fba874120bb40ddeceacbc7ef51217f34d3749de
> 
> Sebastien Goasguen wrote:
>     if these patches apply to master, can you make sure to also apply to master at the same time. thanks

They were already applied to master but missing in 4.2


- Girish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14648/#review28520
-----------------------------------------------------------


On Oct. 15, 2013, 12:10 p.m., Santhosh Edukulla wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14648/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2013, 12:10 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added few naming convention changes--minor.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/deployDataCenter.py beed8c8 
> 
> Diff: https://reviews.apache.org/r/14648/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 14648: Added few changes related to 4870

Posted by Sebastien Goasguen <ru...@gmail.com>.


> On Nov. 8, 2013, 9:15 a.m., Girish Shilamkar wrote:
> > 4.2: fba874120bb40ddeceacbc7ef51217f34d3749de

if these patches apply to master, can you make sure to also apply to master at the same time. thanks


- Sebastien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14648/#review28520
-----------------------------------------------------------


On Oct. 15, 2013, 12:10 p.m., Santhosh Edukulla wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14648/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2013, 12:10 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added few naming convention changes--minor.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/deployDataCenter.py beed8c8 
> 
> Diff: https://reviews.apache.org/r/14648/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 14648: Added few changes related to 4870

Posted by Girish Shilamkar <gi...@clogeny.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14648/#review28520
-----------------------------------------------------------


4.2: fba874120bb40ddeceacbc7ef51217f34d3749de

- Girish Shilamkar


On Oct. 15, 2013, 12:10 p.m., Santhosh Edukulla wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14648/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2013, 12:10 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added few naming convention changes--minor.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/deployDataCenter.py beed8c8 
> 
> Diff: https://reviews.apache.org/r/14648/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>