You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/05/17 09:46:31 UTC
[GitHub] [dolphinscheduler] Yao-MR opened a new issue #5487: [Bug][Module Name] Remove TaskRecordDao
Yao-MR opened a new issue #5487:
URL: https://github.com/apache/dolphinscheduler/issues/5487
Dolphin scheduler 目前已经移除了数据质量检测，
可见在配置文件中也已经移除了对 相关数据质量涉及的db的
但是代码中依旧存在TaskRecordDao对数据质量的query,
并且SELECT * FROM eamp_hive_log_hd WHERE PROC_NAME='%s' and PROC_DATE like '%s'"
中涉及的eamp_hive_log_hd db明显已经不存在于配置的默认数据库中，
但是在重要的抽象类AbstractTask 中依旧存在对
TaskRecordDao的数据质量检测逻辑的判定，建议移除来保持对重要抽象类的纯净
public void after() {
if (getExitStatusCode() == Constants.EXIT_CODE_SUCCESS) {
// task recor flat : if true , start up qianfan
if (TaskRecordDao.getTaskRecordFlag()
&& TaskType.typeIsNormalTask(taskExecutionContext.getTaskType())) {
AbstractParameters params = TaskParametersUtils.getParameters(taskExecutionContext.getTaskType(), taskExecutionContext.getTaskParams());
// replace placeholder
Map<String, Property> paramsMap = ParamUtils.convert(ParamUtils.getUserDefParamsMap(taskExecutionContext.getDefinedParams()),
taskExecutionContext.getDefinedParams(),
params.getLocalParametersMap(),
CommandType.of(taskExecutionContext.getCmdTypeIfComplement()),
taskExecutionContext.getScheduleTime());
if (paramsMap != null && !paramsMap.isEmpty()
&& paramsMap.containsKey("v_proc_date")) {
String vProcDate = paramsMap.get("v_proc_date").getValue();
if (!StringUtils.isEmpty(vProcDate)) {
TaskRecordStatus taskRecordState = TaskRecordDao.getTaskRecordState(taskExecutionContext.getTaskName(), vProcDate);
logger.info("task record status : {}", taskRecordState);
if (taskRecordState == TaskRecordStatus.FAILURE) {
setExitStatusCode(Constants.EXIT_CODE_FAILURE);
}
}
}
}
} else if (getExitStatusCode() == Constants.EXIT_CODE_KILL) {
setExitStatusCode(Constants.EXIT_CODE_KILL);
} else {
setExitStatusCode(Constants.EXIT_CODE_FAILURE);
}
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #5487: [Bug][Module Name] Remove TaskRecordDao
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #5487:
URL: https://github.com/apache/dolphinscheduler/issues/5487#issuecomment-842184161
Hi:
* Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/zh-cn/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] lenboo commented on issue #5487: [Improvement][Task] Remove TaskRecordDao And simply the after() in the AbstractTask class
Posted by GitBox <gi...@apache.org>.
lenboo commented on issue #5487:
URL: https://github.com/apache/dolphinscheduler/issues/5487#issuecomment-842925544
+1
Agree to delete the code about taskRecord
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Yao-MR commented on issue #5487: [Bug][Module Name] Remove TaskRecordDao And simply the after() in the AbstractTask class
Posted by GitBox <gi...@apache.org>.
Yao-MR commented on issue #5487:
URL: https://github.com/apache/dolphinscheduler/issues/5487#issuecomment-842185284
如果可以我将会进行相关设计来进行下一步工作
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #5487: [Bug][Module Name] Remove TaskRecordDao
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #5487:
URL: https://github.com/apache/dolphinscheduler/issues/5487#issuecomment-842184161
Hi:
* Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/zh-cn/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhuangchong commented on issue #5487: [Bug][Module Name] Remove TaskRecordDao And simply the after() in the AbstractTask class
Posted by GitBox <gi...@apache.org>.
zhuangchong commented on issue #5487:
URL: https://github.com/apache/dolphinscheduler/issues/5487#issuecomment-842768931
good idea, you also need to clean up TaskRecord related files, such as Controller, VUE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Yao-MR commented on issue #5487: [Bug][Module Name] Remove TaskRecordDao And simply the after() in the AbstractTask class
Posted by GitBox <gi...@apache.org>.
Yao-MR commented on issue #5487:
URL: https://github.com/apache/dolphinscheduler/issues/5487#issuecomment-842185284
如果可以我将会进行相关设计来进行下一步工作
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] lenboo closed issue #5487: [Improvement][Task] Remove TaskRecordDao And simply the after() in the AbstractTask class
Posted by GitBox <gi...@apache.org>.
lenboo closed issue #5487:
URL: https://github.com/apache/dolphinscheduler/issues/5487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org