You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@nemo.apache.org by GitBox <gi...@apache.org> on 2018/11/02 01:14:56 UTC

[GitHub] johnyangk commented on a change in pull request #141: [NEMO-252] Fix CreatViewTransform to emit windowed materialized data

johnyangk commented on a change in pull request #141: [NEMO-252] Fix CreatViewTransform to emit windowed materialized data
URL: https://github.com/apache/incubator-nemo/pull/141#discussion_r230245464
 
 

 ##########
 File path: compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/GroupByKeyAndWindowDoFnTransform.java
 ##########
 @@ -132,15 +139,26 @@ private void processElementsAndTriggerTimers(final Watermark watermark,
       }
 
       // Trigger timers
-      triggerTimers(key, watermark, processingTime, synchronizedTime);
+      final long keyOutputTimestamp =
 
 Review comment:
   minimumTimestampOfEmittedWindows?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services