[jira] [Commented] (CALCITE-4415) SqlStdOperatorTable.NOT_LIKE has a wrong implementor

["Julian Hyde (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-4415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236738#comment-17236738 ] 

Julian Hyde commented on CALCITE-4415:
--------------------------------------

It appears that NOT LIKE  is not part of the Rex language, and there is no benefit to adding it. So I suggest that you remove the implementor. 

> SqlStdOperatorTable.NOT_LIKE has a wrong implementor
> ----------------------------------------------------
>
>                 Key: CALCITE-4415
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4415
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Ruben Q L
>            Assignee: Ruben Q L
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.27.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> {{SqlStdOperatorTable.NOT_LIKE}}'s implementor defined in {{RexImpTable}} is currently the same as {{LIKE}} (i.e. {{NOT_LIKE}} performs the same operation as {{LIKE}}):
> {code}
> ...
> final MethodImplementor likeImplementor =
>         new MethodImplementor(BuiltInMethod.LIKE.method, NullPolicy.STRICT, false);
> map.put(LIKE, likeImplementor);
> map.put(NOT_LIKE, likeImplementor);
> {code}
> It should be:
> {code}
> ...
> map.put(LIKE, likeImplementor);
> map.put(NOT_LIKE, NotImplementor.of(likeImplementor));
> {code}
> Luckily, SQL queries seem to not suffer the consequences because {{StandardConvertletTable}} expands {{x NOT LIKE y}} into {{NOT (x LIKE y)}}, so the issue is avoided:
> {code}
> // Expand "x NOT LIKE y" into "NOT (x LIKE y)"
> registerOp(SqlStdOperatorTable.NOT_LIKE,
>     (cx, call) -> cx.convertExpression(
>         SqlStdOperatorTable.NOT.createCall(SqlParserPos.ZERO,
>             SqlStdOperatorTable.LIKE.createCall(SqlParserPos.ZERO,
>                 call.getOperandList()))));
> {code}
> However, creating a plan via RelBuilder using {{SqlStdOperatorTable.NOT_LIKE}} will lead to incorrect results.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)