You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/07/20 14:02:03 UTC
Review Request 36616: LENS-667 : Use SLF4j logger in driver modules
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36616/
-----------------------------------------------------------
Review request for lens and Rajat Khandelwal.
Bugs: LENS-667
https://issues.apache.org/jira/browse/LENS-667
Repository: lens
Description
-------
Straight forward patch
Diffs
-----
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 89d671f
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f38b1da
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 0104670
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 18f84cd
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java 7b454fa
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 9445436
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 2687673
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java f534b69
Diff: https://reviews.apache.org/r/36616/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.246s]
[INFO] Lens .............................................. SUCCESS [3.416s]
[INFO] Lens API .......................................... SUCCESS [20.659s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.006s]
[INFO] Lens Cube ......................................... SUCCESS [4:13.652s]
[INFO] Lens DB storage ................................... SUCCESS [18.635s]
[INFO] Lens Query Library ................................ SUCCESS [15.285s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:48.069s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [34.173s]
[INFO] Lens Server ....................................... SUCCESS [5:35.294s]
[INFO] Lens client ....................................... SUCCESS [34.478s]
[INFO] Lens CLI .......................................... SUCCESS [2:37.508s]
[INFO] Lens Examples ..................................... SUCCESS [8.244s]
[INFO] Lens Distribution ................................. SUCCESS [8.001s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:19.603s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.926s]
[INFO] Lens Regression ................................... SUCCESS [12.150s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:34.181s
[INFO] Finished at: Mon Jul 20 12:01:34 UTC 2015
[INFO] Final Memory: 192M/2061M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 36616: LENS-667 : Use SLF4j logger in driver
modules
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On July 20, 2015, 12:20 p.m., Raju Bairishetti wrote:
> > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java, line 264
> > <https://reviews.apache.org/r/36616/diff/1/?file=1016709#file1016709line264>
> >
> > Does not require placeholder **{}** here?
was missed. Added now.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36616/#review92255
-----------------------------------------------------------
On July 20, 2015, 12:24 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36616/
> -----------------------------------------------------------
>
> (Updated July 20, 2015, 12:24 p.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Bugs: LENS-667
> https://issues.apache.org/jira/browse/LENS-667
>
>
> Repository: lens
>
>
> Description
> -------
>
> Straight forward patch
>
>
> Diffs
> -----
>
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 89d671f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f38b1da
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 0104670
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 18f84cd
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java 7b454fa
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 9445436
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 2687673
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java f534b69
>
> Diff: https://reviews.apache.org/r/36616/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.246s]
> [INFO] Lens .............................................. SUCCESS [3.416s]
> [INFO] Lens API .......................................... SUCCESS [20.659s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.006s]
> [INFO] Lens Cube ......................................... SUCCESS [4:13.652s]
> [INFO] Lens DB storage ................................... SUCCESS [18.635s]
> [INFO] Lens Query Library ................................ SUCCESS [15.285s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:48.069s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.173s]
> [INFO] Lens Server ....................................... SUCCESS [5:35.294s]
> [INFO] Lens client ....................................... SUCCESS [34.478s]
> [INFO] Lens CLI .......................................... SUCCESS [2:37.508s]
> [INFO] Lens Examples ..................................... SUCCESS [8.244s]
> [INFO] Lens Distribution ................................. SUCCESS [8.001s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.603s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.926s]
> [INFO] Lens Regression ................................... SUCCESS [12.150s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:34.181s
> [INFO] Finished at: Mon Jul 20 12:01:34 UTC 2015
> [INFO] Final Memory: 192M/2061M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 36616: LENS-667 : Use SLF4j logger in driver
modules
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36616/#review92255
-----------------------------------------------------------
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java (line 264)
<https://reviews.apache.org/r/36616/#comment146318>
Does not require placeholder **{}** here?
- Raju Bairishetti
On July 20, 2015, 12:02 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36616/
> -----------------------------------------------------------
>
> (Updated July 20, 2015, 12:02 p.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Bugs: LENS-667
> https://issues.apache.org/jira/browse/LENS-667
>
>
> Repository: lens
>
>
> Description
> -------
>
> Straight forward patch
>
>
> Diffs
> -----
>
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 89d671f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f38b1da
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 0104670
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 18f84cd
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java 7b454fa
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 9445436
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 2687673
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java f534b69
>
> Diff: https://reviews.apache.org/r/36616/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.246s]
> [INFO] Lens .............................................. SUCCESS [3.416s]
> [INFO] Lens API .......................................... SUCCESS [20.659s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.006s]
> [INFO] Lens Cube ......................................... SUCCESS [4:13.652s]
> [INFO] Lens DB storage ................................... SUCCESS [18.635s]
> [INFO] Lens Query Library ................................ SUCCESS [15.285s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:48.069s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.173s]
> [INFO] Lens Server ....................................... SUCCESS [5:35.294s]
> [INFO] Lens client ....................................... SUCCESS [34.478s]
> [INFO] Lens CLI .......................................... SUCCESS [2:37.508s]
> [INFO] Lens Examples ..................................... SUCCESS [8.244s]
> [INFO] Lens Distribution ................................. SUCCESS [8.001s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.603s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.926s]
> [INFO] Lens Regression ................................... SUCCESS [12.150s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:34.181s
> [INFO] Finished at: Mon Jul 20 12:01:34 UTC 2015
> [INFO] Final Memory: 192M/2061M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 36616: LENS-667 : Use SLF4j logger in driver
modules
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On July 20, 2015, 12:33 p.m., Rajat Khandelwal wrote:
> > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java, line 816
> > <https://reviews.apache.org/r/36616/diff/2/?file=1016749#file1016749line816>
> >
> > All files covered?
Yes. In driver modules.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36616/#review92260
-----------------------------------------------------------
On July 20, 2015, 12:24 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36616/
> -----------------------------------------------------------
>
> (Updated July 20, 2015, 12:24 p.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Bugs: LENS-667
> https://issues.apache.org/jira/browse/LENS-667
>
>
> Repository: lens
>
>
> Description
> -------
>
> Straight forward patch
>
>
> Diffs
> -----
>
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 89d671f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f38b1da
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 0104670
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 18f84cd
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java 7b454fa
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 9445436
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 2687673
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java f534b69
>
> Diff: https://reviews.apache.org/r/36616/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.246s]
> [INFO] Lens .............................................. SUCCESS [3.416s]
> [INFO] Lens API .......................................... SUCCESS [20.659s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.006s]
> [INFO] Lens Cube ......................................... SUCCESS [4:13.652s]
> [INFO] Lens DB storage ................................... SUCCESS [18.635s]
> [INFO] Lens Query Library ................................ SUCCESS [15.285s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:48.069s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.173s]
> [INFO] Lens Server ....................................... SUCCESS [5:35.294s]
> [INFO] Lens client ....................................... SUCCESS [34.478s]
> [INFO] Lens CLI .......................................... SUCCESS [2:37.508s]
> [INFO] Lens Examples ..................................... SUCCESS [8.244s]
> [INFO] Lens Distribution ................................. SUCCESS [8.001s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.603s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.926s]
> [INFO] Lens Regression ................................... SUCCESS [12.150s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:34.181s
> [INFO] Finished at: Mon Jul 20 12:01:34 UTC 2015
> [INFO] Final Memory: 192M/2061M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 36616: LENS-667 : Use SLF4j logger in driver
modules
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36616/#review92260
-----------------------------------------------------------
Ship it!
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java (line 816)
<https://reviews.apache.org/r/36616/#comment146323>
All files covered?
- Rajat Khandelwal
On July 20, 2015, 5:54 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36616/
> -----------------------------------------------------------
>
> (Updated July 20, 2015, 5:54 p.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Bugs: LENS-667
> https://issues.apache.org/jira/browse/LENS-667
>
>
> Repository: lens
>
>
> Description
> -------
>
> Straight forward patch
>
>
> Diffs
> -----
>
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 89d671f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f38b1da
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 0104670
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 18f84cd
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java 7b454fa
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 9445436
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 2687673
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java f534b69
>
> Diff: https://reviews.apache.org/r/36616/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.246s]
> [INFO] Lens .............................................. SUCCESS [3.416s]
> [INFO] Lens API .......................................... SUCCESS [20.659s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.006s]
> [INFO] Lens Cube ......................................... SUCCESS [4:13.652s]
> [INFO] Lens DB storage ................................... SUCCESS [18.635s]
> [INFO] Lens Query Library ................................ SUCCESS [15.285s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:48.069s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.173s]
> [INFO] Lens Server ....................................... SUCCESS [5:35.294s]
> [INFO] Lens client ....................................... SUCCESS [34.478s]
> [INFO] Lens CLI .......................................... SUCCESS [2:37.508s]
> [INFO] Lens Examples ..................................... SUCCESS [8.244s]
> [INFO] Lens Distribution ................................. SUCCESS [8.001s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.603s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.926s]
> [INFO] Lens Regression ................................... SUCCESS [12.150s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:34.181s
> [INFO] Finished at: Mon Jul 20 12:01:34 UTC 2015
> [INFO] Final Memory: 192M/2061M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 36616: LENS-667 : Use SLF4j logger in driver
modules
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36616/
-----------------------------------------------------------
(Updated July 20, 2015, 12:24 p.m.)
Review request for lens and Rajat Khandelwal.
Bugs: LENS-667
https://issues.apache.org/jira/browse/LENS-667
Repository: lens
Description
-------
Straight forward patch
Diffs (updated)
-----
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 89d671f
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f38b1da
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 0104670
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 18f84cd
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DataSourceConnectionProvider.java 7b454fa
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 9445436
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 2687673
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java f534b69
Diff: https://reviews.apache.org/r/36616/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.246s]
[INFO] Lens .............................................. SUCCESS [3.416s]
[INFO] Lens API .......................................... SUCCESS [20.659s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.006s]
[INFO] Lens Cube ......................................... SUCCESS [4:13.652s]
[INFO] Lens DB storage ................................... SUCCESS [18.635s]
[INFO] Lens Query Library ................................ SUCCESS [15.285s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:48.069s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [34.173s]
[INFO] Lens Server ....................................... SUCCESS [5:35.294s]
[INFO] Lens client ....................................... SUCCESS [34.478s]
[INFO] Lens CLI .......................................... SUCCESS [2:37.508s]
[INFO] Lens Examples ..................................... SUCCESS [8.244s]
[INFO] Lens Distribution ................................. SUCCESS [8.001s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:19.603s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.926s]
[INFO] Lens Regression ................................... SUCCESS [12.150s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:34.181s
[INFO] Finished at: Mon Jul 20 12:01:34 UTC 2015
[INFO] Final Memory: 192M/2061M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu