You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Costin Manolache <cm...@yahoo.com> on 2003/03/13 16:02:11 UTC
Dependencies ( was: Re: [GUMP] Build Failure - jakarta-tomcat-5
When we add a new dependency to the code, we should:
1. Update gump
2. Make a small proposal and get a vote
3. Use conditionals if the dependency is not required and update download
target
Dependencies are very important and affect everyone.
I don't remember when fileupload was added to HTMLManagerServlet - but it
certainly doesn't belong to server/lib ( IMO it should go to WEB-INF/lib of
the manager ).
Costin
[/home/rubys/jakarta/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/launcher/CatalinaLaunchFilter.java:69:
> [package org.apache.commons.launcher does not exist javac] import
> [org.apache.commons.launcher.LaunchCommand;
> [javac] ^
> [javac]
[/home/rubys/jakarta/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets/HTMLManagerServlet.java:86:
> [package org.apache.commons.fileupload does not exist javac] import
> [org.apache.commons.fileupload.FileItem;
> [javac] ^
> [javac]
>
[/home/rubys/jakarta/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets/HTMLManagerServlet.java:87:
> [package org.apache.commons.fileupload does not exist javac] import
> [org.apache.commons.fileupload.FileUpload;
> [javac] ^
> [javac]
>
[/home/rubys/jakarta/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets/HTMLManagerServlet.java:88:
> [package org.apache.commons.fileupload does not exist javac] import
> [org.apache.commons.fileupload.FileUploadException;
> [javac] ^
> [javac]
>
[/home/rubys/jakarta/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets/HTMLManagerServlet.java:198:
> [cannot resolve symbol
> [javac] symbol : class FileUpload
> [javac] location: class
> [org.apache.catalina.servlets.HTMLManagerServlet
> [javac] FileUpload upload = new FileUpload();
> [javac] ^
> [javac]
>
[/home/rubys/jakarta/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets/HTMLManagerServlet.java:198:
> [cannot resolve symbol
> [javac] symbol : class FileUpload
> [javac] location: class
> [org.apache.catalina.servlets.HTMLManagerServlet
> [javac] FileUpload upload = new FileUpload();
> [javac] ^
> [javac]
>
[/home/rubys/jakarta/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets/HTMLManagerServlet.java:209:
> [cannot resolve symbol
> [javac] symbol : class FileItem
> [javac] location: class
> [org.apache.catalina.servlets.HTMLManagerServlet
> [javac] FileItem warUpload = null;
> [javac] ^
> [javac]
>
[/home/rubys/jakarta/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets/HTMLManagerServlet.java:216:
> [cannot resolve symbol
> [javac] symbol : class FileItem
> [javac] location: class
> [org.apache.catalina.servlets.HTMLManagerServlet
> [javac] FileItem item = (FileItem) iter.next();
> [javac] ^
> [javac]
>
[/home/rubys/jakarta/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/servlets/HTMLManagerServlet.java:216:
> [cannot resolve symbol
> [javac] symbol : class FileItem
> [javac] location: class
> [org.apache.catalina.servlets.HTMLManagerServlet
> [javac] FileItem item = (FileItem) iter.next();
> [javac] ^
> [javac] Note: Some input files use or override a deprecated API.
> [javac] Note: Recompile with -deprecation for details.
> [javac] 12 errors
>
> BUILD FAILED
> file:///home/rubys/jakarta/jakarta-tomcat-catalina/catalina/build.xml:652:
> Compile failed; see the compiler error output for details.
>
> Total time: 35 seconds
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: Dependencies ( was: Re: [GUMP] Build Failure - jakarta-tomcat-5
Posted by Costin Manolache <cm...@yahoo.com>.
Remy Maucherat wrote:
> Costin Manolache wrote:
>> Remy Maucherat wrote:
>>
>> Well - I tought the rule is that we can't release with dependencies on
>> unreleased or beta code.
>>
>> And HTMLManagerServlet was supposed to be a simple servlet - it now has
>> dependencies on fileupload and that is forced on the whole thing.
>>
>> Glenn: is it ok if we comment this out for 4.1 ? Can you move the upload
>> to a different servlet ? It doesn't have to be in HTMLManager, it can be
>> in a regular standalone webapp.
>
> Quite frankly, I feel lazy about the issue, and don't feel like redoing
> a full release because of that trivial issue.
ok.
Costin
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: Dependencies ( was: Re: [GUMP] Build Failure - jakarta-tomcat-5
Posted by Remy Maucherat <re...@apache.org>.
Costin Manolache wrote:
> Remy Maucherat wrote:
>
> Well - I tought the rule is that we can't release with dependencies on
> unreleased or beta code.
>
> And HTMLManagerServlet was supposed to be a simple servlet - it now has
> dependencies on fileupload and that is forced on the whole thing.
>
> Glenn: is it ok if we comment this out for 4.1 ? Can you move the upload
> to a different servlet ? It doesn't have to be in HTMLManager, it can be in
> a regular standalone webapp.
Quite frankly, I feel lazy about the issue, and don't feel like redoing
a full release because of that trivial issue.
Remy
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: Dependencies ( was: Re: [GUMP] Build Failure - jakarta-tomcat-5
Posted by Costin Manolache <cm...@yahoo.com>.
Remy Maucherat wrote:
> Costin Manolache wrote:
>> When we add a new dependency to the code, we should:
>> 1. Update gump
>> 2. Make a small proposal and get a vote
>> 3. Use conditionals if the dependency is not required and update download
>> target
>>
>> Dependencies are very important and affect everyone.
>>
>> I don't remember when fileupload was added to HTMLManagerServlet - but it
>> certainly doesn't belong to server/lib ( IMO it should go to WEB-INF/lib
>> of the manager ).
>
> The dependency was sneaked in by Glenn (and it is now predictably
> causing moral problems with 4.1.x; I will completely ignore these
> problems, and urge to proceed with the release if this is the only issue).
> I complained at the time, but the functionality appeared useful, so I
> decided not to veto his patch.
Well - I tought the rule is that we can't release with dependencies on
unreleased or beta code.
And HTMLManagerServlet was supposed to be a simple servlet - it now has
dependencies on fileupload and that is forced on the whole thing.
Glenn: is it ok if we comment this out for 4.1 ? Can you move the upload
to a different servlet ? It doesn't have to be in HTMLManager, it can be in
a regular standalone webapp.
Costin
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: Dependencies ( was: Re: [GUMP] Build Failure - jakarta-tomcat-5
Posted by Remy Maucherat <re...@apache.org>.
Costin Manolache wrote:
> When we add a new dependency to the code, we should:
> 1. Update gump
> 2. Make a small proposal and get a vote
> 3. Use conditionals if the dependency is not required and update download
> target
>
> Dependencies are very important and affect everyone.
>
> I don't remember when fileupload was added to HTMLManagerServlet - but it
> certainly doesn't belong to server/lib ( IMO it should go to WEB-INF/lib of
> the manager ).
The dependency was sneaked in by Glenn (and it is now predictably
causing moral problems with 4.1.x; I will completely ignore these
problems, and urge to proceed with the release if this is the only issue).
I complained at the time, but the functionality appeared useful, so I
decided not to veto his patch.
Remy
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org