You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by "Mariia Mykhailova (JIRA)" <ji...@apache.org> on 2015/08/26 21:52:46 UTC

[jira] [Commented] (REEF-645) Remove APIs deprecated since 0.12 from reef-common: Launcher

    [ https://issues.apache.org/jira/browse/REEF-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14715402#comment-14715402 ] 

Mariia Mykhailova commented on REEF-645:
----------------------------------------

There are several comments which refer to {{Launcher}} class. Should we update them to refer to {{REEFLauncher}} instead? 

{noformat}
org/apache/reef/driver/evaluator/EvaluatorProcess.java
   * Set the name of the configuration file for the Launcher. This file is assumed to exist in the working directory of
   * the process launched with this command line.
--
org/apache/reef/runtime/common/driver/evaluator/EvaluatorManager.java
        /* We need to wait awhile before returning the container to the RM in order to
         * give the EvaluatorRuntime (and Launcher) time to cleanly exit. */
--
org/apache/reef/runtime/common/launch/LaunchCommandBuilder.java
   * Set the name of the configuration file for the Launcher. This file is assumed to exist in the working directory of
   * the process launched with this command line.
--
org/apache/reef/runtime/common/launch/parameters/package-info.java
 * Parameters of the Launcher.
{noformat}

> Remove APIs deprecated since 0.12 from reef-common: Launcher
> ------------------------------------------------------------
>
>                 Key: REEF-645
>                 URL: https://issues.apache.org/jira/browse/REEF-645
>             Project: REEF
>          Issue Type: Task
>          Components: REEF-Common
>    Affects Versions: 0.12
>            Reporter: Mariia Mykhailova
>            Assignee: Mariia Mykhailova
>            Priority: Minor
>
> Marked for deprecation in REEF-269
> {noformat}
> --
> lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/LaunchClass.java-44- * @deprecated in 0.12.0. This class is exclusively used by the deprecated Launcher.
> lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/LaunchClass.java:46:@Deprecated
> lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/launch/LaunchClass.java-47-public final class LaunchClass implements AutoCloseable, Runnable {
> --
> lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/Launcher.java:49:@Deprecated
> lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/Launcher.java-50-public final class Launcher {
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)