You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by xy...@apache.org on 2022/05/26 05:07:22 UTC

[pulsar] branch master updated: [Python] Use MacOS 10.15 as the target OS version for Python wheel files (#15788)

This is an automated email from the ASF dual-hosted git repository.

xyz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new 39dfe3691fa [Python] Use MacOS 10.15 as the target OS version for Python wheel files (#15788)
39dfe3691fa is described below

commit 39dfe3691fa23c6d706f74546ccf8367d18e8254
Author: Matteo Merli <mm...@apache.org>
AuthorDate: Wed May 25 22:07:16 2022 -0700

    [Python] Use MacOS 10.15 as the target OS version for Python wheel files (#15788)
    
    ### Motivation
    
    To get broader compatibility for Python wheel files on Mac, we can target MacOS 10.15 instead of 11.0.
---
 pulsar-client-cpp/python/build-mac-wheels.sh | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/pulsar-client-cpp/python/build-mac-wheels.sh b/pulsar-client-cpp/python/build-mac-wheels.sh
index 2fe2da3cd31..6a4dae7117e 100755
--- a/pulsar-client-cpp/python/build-mac-wheels.sh
+++ b/pulsar-client-cpp/python/build-mac-wheels.sh
@@ -27,7 +27,7 @@ PYTHON_VERSIONS=(
    '3.10 3.10.2'
 )
 
-export MACOSX_DEPLOYMENT_TARGET=11.0
+export MACOSX_DEPLOYMENT_TARGET=10.15
 MACOSX_DEPLOYMENT_TARGET_MAJOR=${MACOSX_DEPLOYMENT_TARGET%%.*}
 
 ZLIB_VERSION=1.2.12
@@ -275,18 +275,16 @@ for line in "${PYTHON_VERSIONS[@]}"; do
         ARCHS='x86_64'
     fi
 
+    set -x
     cmake . \
             -DCMAKE_OSX_ARCHITECTURES=${ARCHS} \
             -DCMAKE_OSX_DEPLOYMENT_TARGET=${MACOSX_DEPLOYMENT_TARGET} \
-            -DCMAKE_OSX_SYSROOT=/Library/Developer/CommandLineTools/SDKs/MacOSX${MACOSX_DEPLOYMENT_TARGET_MAJOR}.sdk \
             -DCMAKE_INSTALL_PREFIX=$PREFIX \
-            -DCMAKE_INSTALL_LIBDIR=$PREFIX/lib \
             -DCMAKE_BUILD_TYPE=Release \
             -DCMAKE_PREFIX_PATH=$PREFIX \
             -DCMAKE_CXX_FLAGS=-I$PREFIX/include \
-            -DCMAKE_FIND_FRAMEWORK=$PREFIX \
             -DBoost_INCLUDE_DIR=$CACHE_DIR/boost-py-$PYTHON_VERSION/include \
-            -DBoost_LIBRARY_DIRS=$CACHE_DIR/boost-py-$PYTHON_VERSION/lib \
+            -DBoost_LIBRARY_DIR=$CACHE_DIR/boost-py-$PYTHON_VERSION/lib \
             -DPYTHON_INCLUDE_DIR=$PY_INCLUDE_DIR \
             -DPYTHON_LIBRARY=$PY_PREFIX/lib/libpython${PYTHON_VERSION}.dylib \
             -DLINK_STATIC=ON \