[GitHub] dubeejw commented on a change in pull request #3254: Do not disable rule when it is updated

[GitBox <gi...@apache.org>]

dubeejw commented on a change in pull request #3254: Do not disable rule when it is updated
URL: https://github.com/apache/incubator-openwhisk/pull/3254#discussion_r166838379
 
 

 ##########
 File path: core/controller/src/main/scala/whisk/core/controller/Rules.scala
 ##########
 @@ -313,7 +314,7 @@ trait WhiskRulesApi extends WhiskCollectionAPI with ReferencedEntities {
             WhiskTrigger.put(entityStore, oldTrigger.removeRule(ruleName))
           }
 
-          val triggerLink = ReducedRule(actionName, Status.INACTIVE)
+          val triggerLink = ReducedRule(actionName, status)
 
 Review comment:
   The `create()` method is made in such a way that `active` is always returned for the rule status even if the rule is not actually in an active state. The updated test will fail because of this. If I used `wsk.rule.get()` instead of checking the `wsk.rule.create()` response, the tests would pass. Maybe we need to use `getStatus()` in the `create()` method.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services