You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "JNSimba (via GitHub)" <gi...@apache.org> on 2026/04/15 02:00:18 UTC
[PR] [fix](test) Fix flaky assertion in test_streaming_insert_job_fetch_meta_error [doris]
JNSimba opened a new pull request, #62499:
URL: https://github.com/apache/doris/pull/62499
### What problem does this PR solve?
PR #62023 refactored the filesystem SPI, which changed the error propagation path in `S3SourceOffsetProvider.fetchRemoteMeta()`.
Previously (#61284), the debug point created a `GlobListResult` with an error status, and the subsequent status check threw an exception with message `"Failed to list S3 files: ..."`. After the refactoring in #62023, the debug point was changed to directly throw an `IOException`, which is caught by `StreamingInsertJob.fetchMeta()` and wrapped as `"Failed to fetch meta, ..."`. However, the regression test assertion was not updated accordingly, causing the test to fail intermittently.
### How does this PR fix it?
Update the assertion in `test_streaming_insert_job_fetch_meta_error` from checking `"Failed to list S3 files"` to `"Failed to fetch meta"`, matching the actual error message produced by the current code path.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [x] No need to test or manual test. Explain why:
- [x] This is a test fix — corrects the assertion string to match the actual error message.
### Check List (For Reviewer who is not the Author)
- [ ] Confirm that the problem is correctly described and the solution makes sense
- [ ] Confirm that no Copyright information is lost
- [ ] Confirm that no sensitive data is included (such as S3 keys)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](test) Fix flaky assertion in test_streaming_insert_job_fetch_meta_error [doris]
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba closed pull request #62499: [fix](test) Fix flaky assertion in test_streaming_insert_job_fetch_meta_error
URL: https://github.com/apache/doris/pull/62499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](test) Fix flaky assertion in test_streaming_insert_job_fetch_meta_error [doris]
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba commented on PR #62499:
URL: https://github.com/apache/doris/pull/62499#issuecomment-4258884709
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](test) Fix flaky assertion in test_streaming_insert_job_fetch_meta_error [doris]
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba commented on PR #62499:
URL: https://github.com/apache/doris/pull/62499#issuecomment-4257758172
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](test) Fix flaky assertion in test_streaming_insert_job_fetch_meta_error [doris]
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba commented on PR #62499:
URL: https://github.com/apache/doris/pull/62499#issuecomment-4258753742
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](test) Fix flaky assertion in test_streaming_insert_job_fetch_meta_error [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62499:
URL: https://github.com/apache/doris/pull/62499#issuecomment-4266711649
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](test) Fix flaky assertion in test_streaming_insert_job_fetch_meta_error [doris]
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba commented on PR #62499:
URL: https://github.com/apache/doris/pull/62499#issuecomment-4257757804
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](test) Fix flaky assertion in test_streaming_insert_job_fetch_meta_error [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #62499:
URL: https://github.com/apache/doris/pull/62499#discussion_r3090427194
##########
regression-test/suites/job_p0/streaming_job/test_streaming_insert_job_fetch_meta_error.groovy:
##########
@@ -80,7 +80,7 @@ suite("test_streaming_insert_job_fetch_meta_error", "nonConcurrent") {
def jobStatus = sql """select Status, ErrorMsg from jobs("type"="insert") where Name='${jobName}'"""
assert jobStatus.get(0).get(0) == "PAUSED"
- assert jobStatus.get(0).get(1).contains("Failed to list S3 files")
+ assert jobStatus.get(0).get(1).contains("Failed to fetch meta")
Review Comment:
This broadens the test too much. `StreamingInsertJob.fetchMeta()` prefixes every exception with `Failed to fetch meta, ...`, and `jobs().ErrorMsg` exposes the full `failureReason.getMsg()`, so the debug-point-specific cause is still available here. With only this wrapper check, any unrelated `fetchRemoteMeta()` failure will now pass, so the test stops protecting the regression that `S3SourceOffsetProvider.fetchRemoteMeta.error` is meant to exercise. `test_streaming_insert_job_alter_aksk.groovy` already covers the generic wrapper case.
```suggestion
assert jobStatus.get(0).get(1).contains("Failed to fetch meta")
assert jobStatus.get(0).get(1).contains("debug point: simulated S3 auth error")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](test) Fix flaky assertion in test_streaming_insert_job_fetch_meta_error [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62499:
URL: https://github.com/apache/doris/pull/62499#issuecomment-4248597634
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](test) Fix flaky assertion in test_streaming_insert_job_fetch_meta_error [doris]
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba commented on PR #62499:
URL: https://github.com/apache/doris/pull/62499#issuecomment-4248599527
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](test) Fix flaky assertion in test_streaming_insert_job_fetch_meta_error [doris]
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba commented on PR #62499:
URL: https://github.com/apache/doris/pull/62499#issuecomment-4256914991
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](test) Fix flaky assertion in test_streaming_insert_job_fetch_meta_error [doris]
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba merged PR #62499:
URL: https://github.com/apache/doris/pull/62499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org