You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by da...@apache.org on 2018/11/16 02:29:55 UTC
[incubator-druid] branch master updated: remove backpressure time
from DefaultQueryMetrics pending on-going discussion (#6631)
This is an automated email from the ASF dual-hosted git repository.
davidlim pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git
The following commit(s) were added to refs/heads/master by this push:
new 7b41e23 remove backpressure time from DefaultQueryMetrics pending on-going discussion (#6631)
7b41e23 is described below
commit 7b41e23cbbe55bb40a5a00128525af86e13591f1
Author: David Lim <da...@apache.org>
AuthorDate: Thu Nov 15 19:29:50 2018 -0700
remove backpressure time from DefaultQueryMetrics pending on-going discussion (#6631)
---
.../src/main/java/org/apache/druid/query/DefaultQueryMetrics.java | 3 ++-
.../test/java/org/apache/druid/query/DefaultQueryMetricsTest.java | 5 -----
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/processing/src/main/java/org/apache/druid/query/DefaultQueryMetrics.java b/processing/src/main/java/org/apache/druid/query/DefaultQueryMetrics.java
index 5531614..cc5ad5e 100644
--- a/processing/src/main/java/org/apache/druid/query/DefaultQueryMetrics.java
+++ b/processing/src/main/java/org/apache/druid/query/DefaultQueryMetrics.java
@@ -247,7 +247,8 @@ public class DefaultQueryMetrics<QueryType extends Query<?>> implements QueryMet
@Override
public QueryMetrics<QueryType> reportBackPressureTime(long timeNs)
{
- return reportMillisTimeMetric("query/node/backpressure", timeNs);
+ // Don't emit by default.
+ return this;
}
@Override
diff --git a/processing/src/test/java/org/apache/druid/query/DefaultQueryMetricsTest.java b/processing/src/test/java/org/apache/druid/query/DefaultQueryMetricsTest.java
index 6f837d9..72121b2 100644
--- a/processing/src/test/java/org/apache/druid/query/DefaultQueryMetricsTest.java
+++ b/processing/src/test/java/org/apache/druid/query/DefaultQueryMetricsTest.java
@@ -152,10 +152,5 @@ public class DefaultQueryMetricsTest
actualEvent = cachingEmitter.getLastEmittedEvent().toMap();
Assert.assertEquals("query/node/bytes", actualEvent.get("metric"));
Assert.assertEquals(10L, actualEvent.get("value"));
-
- queryMetrics.reportBackPressureTime(11000001).emit(serviceEmitter);
- actualEvent = cachingEmitter.getLastEmittedEvent().toMap();
- Assert.assertEquals("query/node/backpressure", actualEvent.get("metric"));
- Assert.assertEquals(11L, actualEvent.get("value"));
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org