You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by al...@apache.org on 2017/05/11 18:23:12 UTC
[4/4] kudu git commit: [catalog_manager_tsk-itest] shortened test's
run-time
[catalog_manager_tsk-itest] shortened test's run-time
The longer the test runs the more tables it creates and drops,
and that makes switching from one leader master to another longer.
The presence of some parallel activity exacerbates the problem because
re-elections happen more often. That leads to timeouts on operations
performed by the client.
This patch shortens the test's run time to make it less flaky if running
on inferior VMs with other concurrent activity.
Change-Id: I21cca3d53d033f56f60e46fb5a3f67f5d7e44122
Reviewed-on: http://gerrit.cloudera.org:8080/6854
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves <da...@gmail.com>
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/de1daf28
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/de1daf28
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/de1daf28
Branch: refs/heads/master
Commit: de1daf282f1d045ab2fe3652771f545e67551367
Parents: dce2591
Author: Alexey Serbin <as...@cloudera.com>
Authored: Wed May 10 21:45:28 2017 -0700
Committer: Alexey Serbin <as...@cloudera.com>
Committed: Thu May 11 18:12:08 2017 +0000
----------------------------------------------------------------------
.../integration-tests/catalog_manager_tsk-itest.cc | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/de1daf28/src/kudu/integration-tests/catalog_manager_tsk-itest.cc
----------------------------------------------------------------------
diff --git a/src/kudu/integration-tests/catalog_manager_tsk-itest.cc b/src/kudu/integration-tests/catalog_manager_tsk-itest.cc
index 60bc55d..656d15a 100644
--- a/src/kudu/integration-tests/catalog_manager_tsk-itest.cc
+++ b/src/kudu/integration-tests/catalog_manager_tsk-itest.cc
@@ -52,11 +52,12 @@ class CatalogManagerTskITest : public KuduTest {
num_tservers_(1),
#if defined(ADDRESS_SANITIZER) || defined(THREAD_SANITIZER)
hb_interval_ms_(32),
+ run_time_seconds_(5)
#else
hb_interval_ms_(16),
+ run_time_seconds_(AllowSlowTests() ? 100 : 5)
#endif
- run_time_seconds_(AllowSlowTests() ? 300 : 10) {
-
+ {
cluster_opts_.num_masters = num_masters_;
cluster_opts_.master_rpc_ports = { 11030, 11031, 11032 };
cluster_opts_.num_tablet_servers = num_tservers_;
@@ -64,6 +65,11 @@ class CatalogManagerTskITest : public KuduTest {
// Add common flags for both masters and tservers.
const vector<string> common_flags = {
Substitute("--raft_heartbeat_interval_ms=$0", hb_interval_ms_),
+ // Added a workaround for memory accounting bug, otherwise the assertion
+ // from MemTracker destructor fires in rare cases. Since the memory
+ // accounting code is slated for revamping, let's disable the memory
+ // tracking for this test.
+ "--tablet_transaction_memory_limit_mb=-1",
};
copy(common_flags.begin(), common_flags.end(),
back_inserter(cluster_opts_.extra_master_flags));
@@ -79,7 +85,6 @@ class CatalogManagerTskITest : public KuduTest {
"--leader_failure_max_missed_heartbeat_periods=1.0",
"--master_non_leader_masters_propagate_tsk",
"--tsk_rotation_seconds=2",
- Substitute("--authn_token_validity_seconds=$0", run_time_seconds_),
};
copy(master_flags.begin(), master_flags.end(),
back_inserter(cluster_opts_.extra_master_flags));
@@ -101,7 +106,7 @@ class CatalogManagerTskITest : public KuduTest {
using ::kudu::client::sp::shared_ptr;
static const char* kTableName = "test-table";
// Using the setting for both RPC and admin operation timeout.
- const MonoDelta timeout = MonoDelta::FromSeconds(run_time_seconds_);
+ const MonoDelta timeout = MonoDelta::FromSeconds(600);
KuduClientBuilder builder;
builder.default_admin_operation_timeout(timeout).default_rpc_timeout(timeout);
shared_ptr<KuduClient> client;