You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/13 08:36:00 UTC

[GitHub] [flink] deadwind4 commented on a diff in pull request #19777: [hotfix][connector/pulsar][docs] Update atEventTime to atPublishTime in JavaDoc

deadwind4 commented on code in PR #19777:
URL: https://github.com/apache/flink/pull/19777#discussion_r895463825


##########
flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/PulsarSourceBuilder.java:
##########
@@ -107,7 +107,7 @@
  *     .setSubscriptionName("flink-source-1")
  *     .setTopics(Arrays.asList(TOPIC1, TOPIC2))
  *     .setDeserializationSchema(PulsarDeserializationSchema.flinkSchema(new SimpleStringSchema()))
- *     .setUnboundedStopCursor(StopCursor.atEventTime(System.currentTimeMillis()))
+ *     .setUnboundedStopCursor(StopCursor.atPublishTime(System.currentTimeMillis()))

Review Comment:
   After I read the source code, I found the core logic of this [PR](https://github.com/apache/flink/pull/18345/files) is renaming `atEventTime` to `atPublishTime` and making `atEventTime` deprecated. @MartijnVisser 
   
   @imaffe  What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org