You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by "chickenlj (GitHub)" <gi...@apache.org> on 2018/12/17 07:14:49 UTC

[GitHub] [incubator-dubbo] chickenlj opened issue #2984: Code refactoring suggestion for ActivesLimitFilter

![14_40_00__12_17_2018](https://user-images.githubusercontent.com/18097545/50071839-15cc0280-020e-11e9-8303-7323927e0ec3.jpg)

This is a code snippet comes from `ActivesLimitFilter`, `count` and `RpcStatus` refers to the same instance, the mixed usage of these two ways are quite confusing.


[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2984 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] chickenlj commented on issue #2984: Code refactoring suggestion for ActivesLimitFilter

Posted by "chickenlj (GitHub)" <gi...@apache.org>.

@danielamorais Cool, please, send one PR and link to this issue once done.

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2984 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] danielamorais commented on issue #2984: Code refactoring suggestion for ActivesLimitFilter

Posted by "danielamorais (GitHub)" <gi...@apache.org>.

I'm interested in working on this issue

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2984 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh commented on issue #2984: Code refactoring suggestion for ActivesLimitFilter

Posted by "carryxyh (GitHub)" <gi...@apache.org>.

Hi, @danielamorais 
Welcome! Looking forward to your pull request.
By the way, I recommend you to participate in our mailing list and share your thoughts

http://dubbo.apache.org/en-us/docs/developers/contributor-guide/mailing-list-subscription-guide_dev.html

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2984 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] zonghaishang closed issue #2984: Code refactoring suggestion for ActivesLimitFilter

Posted by "zonghaishang (GitHub)" <gi...@apache.org>.

[ issue closed by zonghaishang ]

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2984 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org