You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/13 11:32:02 UTC
[GitHub] [nuttx] PeterBee97 opened a new pull request, #8108: arch/sim: add arch/math.h
PeterBee97 opened a new pull request, #8108:
URL: https://github.com/apache/nuttx/pull/8108
## Summary
Direct inclusion of <math.h> will introduce the ```__GLIBC__``` symbol into build. Added arch specific header to strip unneeded macros.
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8108: arch/sim: add arch/math.h
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #8108:
URL: https://github.com/apache/nuttx/pull/8108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8108: arch/sim: add arch/math.h
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #8108:
URL: https://github.com/apache/nuttx/pull/8108#discussion_r1070221975
##########
arch/sim/Kconfig:
##########
@@ -14,6 +14,7 @@ config HOST_X86_64
bool "x86_64"
select ARCH_HAVE_STACKCHECK
select LIBC_ARCH_ELF_64BIT if LIBC_ARCH_ELF && !SIM_M32
+ select ARCH_HAVE_MATH_H
config HOST_X86
Review Comment:
need select for HOST_X86 and HOST_X86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org