You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/03/19 03:52:39 UTC
[GitHub] [incubator-apisix] dabue opened a new pull request #1300: doc:
update Quickstart's step2 to try the getting started guide in README_CN.md
dabue opened a new pull request #1300: doc: update Quickstart's step2 to try the getting started guide in README_CN.md
URL: https://github.com/apache/incubator-apisix/pull/1300
NOTE: Please read the Contributing.md guidelines before submitting your patch:
https://github.com/apache/incubator-apisix/blob/master/Contributing.md#how-to-add-a-new-feature-or-change-an-existing-one
### Summary
SUMMARY_HERE
### Full changelog
* [Implement ...]
* [Add related tests]
* ...
### Issues resolved
Fix #1289
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] dabue commented on a change in pull request
#1300: doc: update Quickstart's step2 to try the getting started guide in
README_CN.md
Posted by GitBox <gi...@apache.org>.
dabue commented on a change in pull request #1300: doc: update Quickstart's step2 to try the getting started guide in README_CN.md
URL: https://github.com/apache/incubator-apisix/pull/1300#discussion_r394806918
##########
File path: README_CN.md
##########
@@ -132,9 +132,9 @@ CentOS 7, Ubuntu 16.04, Ubuntu 18.04, Debian 9, Debian 10, macOS, **[ARM64](http
sudo apisix start
```
-2. 测试限流插件
+2. 入门指南
-你可以测试限流插件,来上手体验 APISIX,按照[限流插件文档](doc/plugins/limit-count-cn.md)的步骤即可。
+入门指南是学习APISIX基础知识的好方法。按照 [入门指南](doc/getting-started.md)的步骤即可。
Review comment:
I have updated it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on issue #1300: doc: update
Quickstart's step2 to try the getting started guide in README_CN.md
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1300: doc: update Quickstart's step2 to try the getting started guide in README_CN.md
URL: https://github.com/apache/incubator-apisix/pull/1300#issuecomment-601011295
merged, many thx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] dabue commented on a change in pull request
#1300: doc: update Quickstart's step2 to try the getting started guide in
README_CN.md
Posted by GitBox <gi...@apache.org>.
dabue commented on a change in pull request #1300: doc: update Quickstart's step2 to try the getting started guide in README_CN.md
URL: https://github.com/apache/incubator-apisix/pull/1300#discussion_r394805811
##########
File path: README_CN.md
##########
@@ -132,9 +132,9 @@ CentOS 7, Ubuntu 16.04, Ubuntu 18.04, Debian 9, Debian 10, macOS, **[ARM64](http
sudo apisix start
```
-2. 测试限流插件
+2. 入门指南
-你可以测试限流插件,来上手体验 APISIX,按照[限流插件文档](doc/plugins/limit-count-cn.md)的步骤即可。
+入门指南是学习APISIX基础知识的好方法。按照 [入门指南](doc/getting-started.md)的步骤即可。
Review comment:
I got it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis merged pull request #1300: doc: update
Quickstart's step2 to try the getting started guide in README_CN.md
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #1300: doc: update Quickstart's step2 to try the getting started guide in README_CN.md
URL: https://github.com/apache/incubator-apisix/pull/1300
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on a change in pull request
#1300: doc: update Quickstart's step2 to try the getting started guide in
README_CN.md
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1300: doc: update Quickstart's step2 to try the getting started guide in README_CN.md
URL: https://github.com/apache/incubator-apisix/pull/1300#discussion_r394783747
##########
File path: README_CN.md
##########
@@ -132,9 +132,9 @@ CentOS 7, Ubuntu 16.04, Ubuntu 18.04, Debian 9, Debian 10, macOS, **[ARM64](http
sudo apisix start
```
-2. 测试限流插件
+2. 入门指南
-你可以测试限流插件,来上手体验 APISIX,按照[限流插件文档](doc/plugins/limit-count-cn.md)的步骤即可。
+入门指南是学习APISIX基础知识的好方法。按照 [入门指南](doc/getting-started.md)的步骤即可。
Review comment:
need a space between Chinese and English
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services