You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/02/12 17:32:49 UTC
[GitHub] flink pull request #5469: [FLINK-8475][config][docs] Integrate Core options
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5469
[FLINK-8475][config][docs] Integrate Core options
## What is the purpose of the change
This PR integrates the core `ConfigOptions` into the configuration docs generator.
Do note that i cheated a bit and manually cut out the fs/env options from the table that are moved to separate tables in #5468 and #5459.
## Brief change log
* Add missing descriptions to config options (derived from existing description/javadocs)
* integrate core configuration table into `config.md`
* added `CoreOptions#TMP_DIRS` to the set of options for which the generated overrides the default
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 8475_core
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5469.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5469
----
commit 037c8bc93193c7aefb7a56412bba74fdbf39e92d
Author: zentol <ch...@...>
Date: 2018-01-30T13:58:32Z
[FLINK-8475][config][docs] Integrate Core options
----
---
[GitHub] flink issue #5469: [FLINK-8475][config][docs] Integrate Core options
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5469
merging.
---
[GitHub] flink pull request #5469: [FLINK-8475][config][docs] Integrate Core options
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5469
---
[GitHub] flink issue #5469: [FLINK-8475][config][docs] Integrate Core options
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5469
Ok, sounds fine to me then. 👍
---
[GitHub] flink issue #5469: [FLINK-8475][config][docs] Integrate Core options
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5469
Couldn't these be called "Classloader options" and have their own group? That way you don't have to manually mess with the generated table.
---
[GitHub] flink issue #5469: [FLINK-8475][config][docs] Integrate Core options
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5469
I only did that for the sake of this PR to avoid merge conflicts; this won't be necessary in the future.
---