You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/12/23 08:10:20 UTC
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1601: Align SparkStatementEvent to KyuubiOperationEvent
ulysses-you commented on a change in pull request #1601:
URL: https://github.com/apache/incubator-kyuubi/pull/1601#discussion_r774391582
##########
File path: externals/kyuubi-spark-sql-engine/src/test/scala/org/apache/kyuubi/engine/spark/events/EngineEventsStoreSuite.scala
##########
@@ -114,10 +162,58 @@ class EngineEventsStoreSuite extends KyuubiFunSuite {
val store = new EngineEventsStore(conf)
- store.saveStatement(SparkStatementEvent("a", "s1", "select 1", "a1", "si1", 1L, "RUNNING", -1L))
- store.saveStatement(SparkStatementEvent("a", "s2", "select 1", "a2", "si1", 2L, "RUNNING", -1L))
- store.saveStatement(SparkStatementEvent("a", "s3", "1", "a3", "si1", 3L, "ERROR", 3L, 3L))
- store.saveStatement(SparkStatementEvent("a", "s4", "select 1", "a4", "si1", 4L, "RUNNING", -1L))
+ store.saveStatement(SparkOperationEvent(
+ "s1",
+ "select 1",
+ true,
+ "RUNNING",
+ 1L,
+ 1L,
+ 1L,
+ -1L,
+ None,
+ "sid1",
+ "a",
+ ""))
+ store.saveStatement(SparkOperationEvent(
+ "s2",
+ "select 1",
+ true,
+ "RUNNING",
+ 2L,
+ 2L,
+ 2L,
+ -1L,
+ None,
+ "sid1",
+ "a",
+ ""))
+ store.saveStatement(SparkOperationEvent(
+ "s3",
+ "select 1",
+ true,
+ "RUNNING",
+ 3L,
+ 3L,
+ 3L,
+ 3L,
+ None,
+ "sid1",
+ "a",
+ ""))
+ store.saveStatement(SparkOperationEvent(
+ "s4",
+ "select 1",
+ true,
+ "RUNNING",
+ 4L,
+ 4L,
+ 4L,
+ -1L,
+ None,
+ "sid1",
+ "a",
+ ""))
Review comment:
this style make me angry ..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org