You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/08/29 00:42:51 UTC
[GitHub] [helix] pkuwm opened a new issue #1331: PreFetch annotation for CallbackHandler class is not honored in ZkClient
pkuwm opened a new issue #1331:
URL: https://github.com/apache/helix/issues/1331
### Describe the bug
PreFetch annotation in class `CallbackHandler` is using `org.apache.helix.api.listeners.PreFetch`:
https://github.com/apache/helix/blob/a5cddd4b8fa51b1ea53b2f7082daf79361cd81de/helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java#L106-L107
Then when it is disabled, the value is not honor in ZkClient. So ZkClient still prefetches the data for callback handler. Because in ZkClient, the annotation `org.apache.helix.zookeeper.zkclient.annotation.PreFetch` is used.
### To Reproduce
Steps to reproduce the behavior.
### Expected behavior
PreFetch disabled in CallbackHandler should be honored in ZkClient. No prefetch for CallbackHandler in ZkClient.
### Additional context
There are two layers of prefetch: one in helix-core for callbackhandler/helix listeners(eg. InstanceConfigChangeListener), the other one in zookeeper-api for ZkClient. We want to separate these purposes by using different annotations. So the existing annotation in zookeeper-api `org.apache.helix.zookeeper.zkclient.annotation.PreFetch` is proposed to change to `org.apache.helix.zookeeper.zkclient.annotation.PreFetchChangedData`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm edited a comment on issue #1331: PreFetch annotation for CallbackHandler class is not honored in ZkClient
Posted by GitBox <gi...@apache.org>.
pkuwm edited a comment on issue #1331:
URL: https://github.com/apache/helix/issues/1331#issuecomment-683212819
@lei-xia
This is a test log to prove prefetch is done in zkclient:
```
START test at Fri Aug 28 18:14:19 PDT 2020
==== update instance config
Prefetch data for path /TestCallbackPrefetch/CONFIGS/PARTICIPANT/localhost_12918
=== after
```
After the fix, no prefetch:
```
START test at Fri Aug 28 18:17:51 PDT 2020
==== update instance config
=== after
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm commented on issue #1331: PreFetch annotation for CallbackHandler class is not honored in ZkClient
Posted by GitBox <gi...@apache.org>.
pkuwm commented on issue #1331:
URL: https://github.com/apache/helix/issues/1331#issuecomment-683212819
@lei-xia
This is a test log to prove prefetch is done in zkclient:
```
START test at Fri Aug 28 18:14:19 PDT 2020
==== update instance config
Prefetch data for path /TestCallbackPrefetch/CONFIGS/PARTICIPANT/localhost_12918
=== after
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm closed issue #1331: PreFetch annotation for CallbackHandler class is not honored in ZkClient
Posted by GitBox <gi...@apache.org>.
pkuwm closed issue #1331:
URL: https://github.com/apache/helix/issues/1331
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org