[jira] [Commented] (HADOOP-9646) Inconsistent exception specifications in FileUtils#chmod

["Colin Patrick McCabe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-9646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703762#comment-13703762 ] 

Colin Patrick McCabe commented on HADOOP-9646:
----------------------------------------------

Hi Karthik, Suresh,

I think everyone wants this to go in, right?  Both you guys gave this a +1 earlier.

I think if we have wider points to make about compatibility, we should do it in a mailing list thread or another JIRA.  It's kind of out of scope for this, since it's just a small change.

Can I get a +1 on this to make it official?
                
> Inconsistent exception specifications in FileUtils#chmod
> --------------------------------------------------------
>
>                 Key: HADOOP-9646
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9646
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>             Fix For: 2.1.0-beta
>
>         Attachments: HADOOP-9646.001.patch, HADOOP-9646.002.patch
>
>
> There are two FileUtils#chmod methods:
> {code}
> public static int chmod(String filename, String perm
>                           ) throws IOException, InterruptedException;
> public static int chmod(String filename, String perm, boolean recursive)
>                             throws IOException;
> {code}
> The first one just calls the second one with {{recursive = false}}, but despite that it is declared as throwing {{InterruptedException}}, something the second one doesn't declare.
> The new Java7 chmod API, which we will transition to once JDK6 support is dropped, does *not* throw {{InterruptedException}}
> See [http://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html#setOwner(java.nio.file.Path, java.nio.file.attribute.UserPrincipal)]
> So we should make these consistent by removing the {{InterruptedException}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira