You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Pier Fumagalli <pi...@betaversion.org> on 2002/04/03 13:08:46 UTC
[PATCH] Remove compiled-in directory names from MPM...
There are a bunch of hard-coded "logs/..." file names in HTTPD's MPM
directory (grep "logs/" server/mpm/*/*).
This patch adds a new header file (ap_config_layout.h), which contains
../configure-specified layout information, and makes all those #define(s) in
MPM to inherit default values from what has been specified in ./configure
rather than hard coded server-root relative paths...
Pier
Re: [PATCH] Remove compiled-in directory names from MPM...
Posted by Pier Fumagalli <pi...@betaversion.org>.
"Aaron Bannert" <aa...@clove.org> wrote:
> On Wed, Apr 03, 2002 at 12:08:46PM +0100, Pier Fumagalli wrote:
>> There are a bunch of hard-coded "logs/..." file names in HTTPD's MPM
>> directory (grep "logs/" server/mpm/*/*).
>>
>> This patch adds a new header file (ap_config_layout.h), which contains
>> ../configure-specified layout information, and makes all those #define(s) in
>> MPM to inherit default values from what has been specified in ./configure
>> rather than hard coded server-root relative paths...
>
> Pier, I haven't tested this, but this is awesome and was badly needed!!
> Good job! +1
One day of boredom trying to APRize Java or Javize APR :) Got some spare
cycles :) :) :)
Pier
Re: [PATCH] Remove compiled-in directory names from MPM...
Posted by Aaron Bannert <aa...@clove.org>.
On Wed, Apr 03, 2002 at 12:08:46PM +0100, Pier Fumagalli wrote:
> There are a bunch of hard-coded "logs/..." file names in HTTPD's MPM
> directory (grep "logs/" server/mpm/*/*).
>
> This patch adds a new header file (ap_config_layout.h), which contains
> ../configure-specified layout information, and makes all those #define(s) in
> MPM to inherit default values from what has been specified in ./configure
> rather than hard coded server-root relative paths...
Pier, I haven't tested this, but this is awesome and was badly needed!!
Good job! +1
-aaron
Re: [PATCH] Remove compiled-in directory names from MPM...
Posted by Pier Fumagalli <pi...@betaversion.org>.
"Sander Striker" <st...@apache.org> wrote:
>> From: Pier Fumagalli [mailto:pier@betaversion.org]
>> Sent: 03 April 2002 13:09
>
>> There are a bunch of hard-coded "logs/..." file names in HTTPD's MPM
>> directory (grep "logs/" server/mpm/*/*).
>>
>> This patch adds a new header file (ap_config_layout.h), which contains
>> .../configure-specified layout information, and makes all those #define(s) in
>> MPM to inherit default values from what has been specified in ./configure
>> rather than hard coded server-root relative paths...
>
> +1 for this change. It would be nice to have all the layout specific
> stuff in one place.
Thanks Sander :) BTW, forgot a little apachectl.in patch as well...
Index: apachectl.in
===================================================================
RCS file: /home/cvspublic/httpd-2.0/support/apachectl.in,v
retrieving revision 1.10
diff -U3 -r1.10 apachectl.in
--- apachectl.in 13 Mar 2002 20:48:05 -0000 1.10
+++ apachectl.in 3 Apr 2002 11:21:18 -0000
@@ -26,14 +26,14 @@
# -------------------- --------------------
#
# the path to your PID file
-PIDFILE=@prefix@/logs/@progname@.pid
+PIDFILE=@exp_runtimedir@/@progname@.pid
#
# the path to your httpd binary, including options if necessary
-HTTPD='@prefix@/bin/@progname@'
+HTTPD='@exp_bindir@/@progname@'
#
# pick up any necessary environment variables
-if test -f @prefix@/bin/envvars; then
- . @prefix@/bin/envvars
+if test -f @exp_bindir@/envvars; then
+ . @exp_bindir@/envvars
fi
#
# a command that outputs a formatted text version of the HTML at the
I'm rebuilding Apache 2.0 with a totally non-standard directory layout
(bundle installation on MacOS/X, all paths are screwed up! :), if I catch
something else, will let you know...
Pier
RE: [PATCH] Remove compiled-in directory names from MPM...
Posted by Sander Striker <st...@apache.org>.
> From: Pier Fumagalli [mailto:pier@betaversion.org]
> Sent: 03 April 2002 13:09
> There are a bunch of hard-coded "logs/..." file names in HTTPD's MPM
> directory (grep "logs/" server/mpm/*/*).
>
> This patch adds a new header file (ap_config_layout.h), which contains
> .../configure-specified layout information, and makes all those #define(s) in
> MPM to inherit default values from what has been specified in ./configure
> rather than hard coded server-root relative paths...
+1 for this change. It would be nice to have all the layout specific
stuff in one place.
Sander
Re: [PATCH] Remove compiled-in directory names from MPM...
Posted by Pier Fumagalli <pi...@betaversion.org>.
Whops... Left one extra "logs" in there... Thanks sander...
Pier