[GitHub] shaofengshi commented on a change in pull request #325: KYLIN-3663 fix deleting project error when project has more than one …

[GitBox <gi...@apache.org>]

shaofengshi commented on a change in pull request #325: KYLIN-3663 fix deleting project error when project has more than one …
URL: https://github.com/apache/kylin/pull/325#discussion_r230588909
 
 

 ##########
 File path: server-base/src/main/java/org/apache/kylin/rest/service/ProjectService.java
 ##########
 @@ -137,8 +138,10 @@ public ProjectInstance updateProject(ProjectInstance newProject, ProjectInstance
     @PreAuthorize(Constant.ACCESS_HAS_ROLE_ADMIN)
     public void deleteProject(String projectName, ProjectInstance project) throws IOException {
         Set<String> tables = project.getTables();
-        for (String table : tables) {
+        for (String table : Sets.newTreeSet(tables)) {
 
 Review comment:
   What's the reason to create a new set? Can you provide more information?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services