[jira] [Comment Edited] (INFRA-9988) Spark GitHub PRs didn't get closed automatically after merge

["Geoffrey Corey (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/INFRA-9988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625229#comment-14625229 ] 

Geoffrey Corey edited comment on INFRA-9988 at 7/13/15 7:54 PM:
----------------------------------------------------------------

Right now, it looks like the API for closing PRs on GitHub has changed, so asfgit-admin isn't closing PRs correctly.

To quote [~humbedooh] from earlier today: "Our immediate findings seem to show that nothing is wrong on our end, but that GitHub might be experiencing some issues or have changed the logic behind pull requests a bit.

We're looking into it, but we have no solution at the moment."

As for granting access: it is not possible at the time because the permissions are not granular enough. As it stand currently, if you have enough access to close issues/PRs, you have write access to the GitHub mirror.

I have gone ahead an manually closed the PR for now.



was (Author: coreyg):
Right now, it looks like the API for closing PRs on gitHub has changed, so asfgi-admin isn't closing PRs correctly.

To quote [~humbedooh] from earlier today: "Our immediate findings seem to show that nothing is wrong on our end, but that GitHub might be experiencing some issues or have changed the logic behind pull requests a bit.

We're looking into it, but we have no solution at the moment."

As for granting access: it is not possible at the time because the permissions are not granular enough. As it stand currently, if you have enough access to close issues/PRs, you have write access to the GitHub mirror.

I have gone ahead an manually closed the PR for now.


> Spark GitHub PRs didn't get closed automatically after merge
> ------------------------------------------------------------
>
>                 Key: INFRA-9988
>                 URL: https://issues.apache.org/jira/browse/INFRA-9988
>             Project: Infrastructure
>          Issue Type: Bug
>          Components: Git
>            Reporter: Xiangrui Meng
>            Assignee: Geoffrey Corey
>
> Many recent PR remained open after merge, for example, https://github.com/apache/spark/pull/7367. This might be related to INFRA-9782. Since this issue happens from time to time, it would be nice to grant Spark PMCs (or committers) access to close PRs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)