[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #1528: [NETBEANS-519] Update jgit

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #1528: [NETBEANS-519] Update jgit
URL: https://github.com/apache/netbeans/pull/1528#discussion_r342256212
 
 

 ##########
 File path: ide/libs.git/src/org/netbeans/libs/git/jgit/commands/MoveTreeCommand.java
 ##########
 @@ -72,12 +70,14 @@ protected MoveTreeCommand (Repository repository, GitClassFactory gitFactory, Fi
 
     @Override
     protected void run() throws GitException {
+        File sourceFile = tryNormalizeSymlink(this.source);
+        File targetFile = tryNormalizeSymlink(this.target);
         if (!keepSourceTree && !after) {
             rename();
         }
+        sourceFile = tryNormalizeSymlink(sourceFile);
 
 Review comment:
   I think I wanted to make sure, that is called in any case. The calls after the rename might suffice though. Would you mind keeping it as is?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists