[jira] [Updated] (HBASE-5045) Add the table name and cf name for the next call int the task monitor

["Phabricator (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phabricator updated HBASE-5045:
-------------------------------

    Attachment: D3045.1.patch

amirshim requested code review of "[jira] [HBASE-5045] Annotation for Custom Param formatting and next() RPC call info".
Reviewers: mbautin, Liyin, tedyu, stack, JIRA, nspiegelberg

  Porting Amir's fix from 89-fb. His original summary below.

  A method for associating pretty print classes with method calls.
  These allow you to get information about a method call given the params it was
  called with and what instance it was called on.

  The first use case is for getting info about a next() RPC call.

TEST PLAN
  Original test plan from Amir: run a script that stresses a
  regionserver with scan and next() scans, and check that the information is show
  in the JSON view of the TaskMonitor

REVISION DETAIL
  https://reviews.facebook.net/D3045

AFFECTED FILES
  src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
  src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
  src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredRPCHandler.java
  src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredRPCHandlerImpl.java
  src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredTask.java
  src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredTaskImpl.java
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
  src/main/java/org/apache/hadoop/hbase/util/ParamFormat.java
  src/main/java/org/apache/hadoop/hbase/util/ParamFormatHelper.java
  src/main/java/org/apache/hadoop/hbase/util/ParamFormatter.java
  src/test/java/org/apache/hadoop/hbase/util/TestParamFormatter.java

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/6915/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

                
> Add the table name and cf name for the next call int the task monitor
> ---------------------------------------------------------------------
>
>                 Key: HBASE-5045
>                 URL: https://issues.apache.org/jira/browse/HBASE-5045
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Liyin Tang
>            Assignee: Amir Shimoni
>         Attachments: D2913.1.patch, D2913.2.patch, D3045.1.patch
>
>
> In the task monitor, we don't have much information about the next call compared to other operations.
> It would be nice to add the table name and cf name for each next call in the task monitor.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira