You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by GitBox <gi...@apache.org> on 2019/09/13 14:57:51 UTC
[GitHub] [lucene-solr] iverase opened a new pull request #878: LUCENE-8746:
Refactor EdgeTree
iverase opened a new pull request #878: LUCENE-8746: Refactor EdgeTree
URL: https://github.com/apache/lucene-solr/pull/878
Another try in refactoring edge tree. This PR splits Edge Tree class into two and adds a new interface:
* Component2D: Interface defining an object that knows its bounding box and can perform some spatial operations.
* ComponentTree: An interval tree containing the different components (e.g polygon or line)
* EdgeTree: An interval tree containing the edges of a components (polygon or line edges)
Unfortunately the PR touches quite a lots of files but most of them are test files. Running benchmark for points results look good, points shows same performance and there is an increase of performance for shapes (we are not computing the bounding box of the triangle many times).
|Approach|Shape|M hits/sec Dev|M hits/sec Base|Diff| QPS Dev| QPS Base|Diff|Hit count Dev|Hit count Base|Diff|
|--- | --- | --- | --- | --- | --- | --- | --- | --- | --- | --- |
|points|polyRussia|13.97|13.98|-0%|3.98|3.99|-0%|3508846|3508846| 0%|
|points|poly 10|73.35|71.84| 2%|46.39|45.43| 2%|355809475|355809475| 0%|
|points|polyMedium|8.73|8.67| 1%|106.99|106.24| 1%|2693559|2693559| 0%|
|shapes|polyRussia|6.88|5.73|20%|1.96|1.63|20%|3508846|3508846| 0%|
|shapes|poly 10|27.98|27.03| 4%|17.69|17.10| 4%|355809475|355809475| 0%|
|shapes|polyMedium|2.79|2.75| 2%|34.19|33.66| 2%|2693559|2693559| 0%|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org