You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/25 14:26:33 UTC

[GitHub] StefanRRichter commented on a change in pull request #7813: [FLINK-10712] Support to restore state when using RestartPipelinedRegionStrategy

StefanRRichter commented on a change in pull request #7813: [FLINK-10712] Support to restore state when using RestartPipelinedRegionStrategy
URL: https://github.com/apache/flink/pull/7813#discussion_r259835513
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/FailoverRegion.java
 ##########
 @@ -73,10 +79,21 @@ public FailoverRegion(
 
 		this.executionGraph = checkNotNull(executionGraph);
 		this.connectedExecutionVertexes = checkNotNull(connectedExecutions);
+		this.tasks = initTasks(connectedExecutionVertexes);
 
 Review comment:
   We could wrap this into an `UnmodifiableMap` because it is supposed to be only manipulated once in the constructor, but the field is exposed through a getter.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services