You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@commons.apache.org by PascalSchumacher <gi...@git.apache.org> on 2017/10/15 10:16:46 UTC

[GitHub] commons-text pull request #70: partial automated migration to assertj

GitHub user PascalSchumacher opened a pull request:

    https://github.com/apache/commons-text/pull/70

    partial automated migration to assertj

    Migrated using a modified version of https://github.com/joel-costigliola/assertj-core/blob/master/src/main/scripts/convert-junit-assertions-to-assertj.sh
    
    I reverted changes where the automated migration did not work to minimize effort for this prototype.
    
    The script use only the most basic assertj assertions, so the full power is not evident.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PascalSchumacher/commons-text partial_automated_migration_to_assertj

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-text/pull/70.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #70
    
----
commit 9fd5bdd5973e64c1fbdce230f21d038c5eee0502
Author: Pascal Schumacher <pa...@gmx.net>
Date:   2017-10-15T10:11:39Z

    partial automated migration to assertj

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

[GitHub] commons-text issue #70: partial automated migration to assertj

Posted by kinow <gi...@git.apache.org>.

Github user kinow commented on the issue:

    https://github.com/apache/commons-text/pull/70
  
    I thought we were using Java 8, but [text] is actually using Java 7. I thought there was some discussion around the minimum requirement for the latest version of assertj being Java 8? So I assume it's safe to start with 2.8.0 now, and bump up to 3.8.0 later when we upgrade do Java 8?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

[GitHub] commons-text issue #70: partial automated migration to assertj

Posted by britter <gi...@git.apache.org>.

Github user britter commented on the issue:

    https://github.com/apache/commons-text/pull/70
  
    Cool! Have missed the discussion about introducing this for Text. I like it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

[GitHub] commons-text issue #70: partial automated migration to assertj

Posted by kinow <gi...@git.apache.org>.

Github user kinow commented on the issue:

    https://github.com/apache/commons-text/pull/70
  
    Looks good to me. Given [text] is already on Java 8, I believe it's a good candidate to start using assertj.
    
    >The script use only the most basic assertj assertions, so the full power is not evident.
    
    Indeed. But I like this approach. We introduce assertj, migrate the old assertions, and only then we start replacing/simplifying parts of the tests. And new text code can also be written with assertj.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

[GitHub] commons-text issue #70: partial automated migration to assertj

Posted by coveralls <gi...@git.apache.org>.

Github user coveralls commented on the issue:

    https://github.com/apache/commons-text/pull/70
  
    
    [![Coverage Status](https://coveralls.io/builds/13921641/badge)](https://coveralls.io/builds/13921641)
    
    Coverage remained the same at 98.298% when pulling **34a7dc3345b2b0acd2d91d932e38044b60f14ee7 on PascalSchumacher:partial_automated_migration_to_assertj** into **6665a02096fc56ad5a60943f65d6f75aea389cf7 on apache:master**.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

[GitHub] commons-text issue #70: partial automated migration to assertj

Posted by coveralls <gi...@git.apache.org>.

Github user coveralls commented on the issue:

    https://github.com/apache/commons-text/pull/70
  
    
    [![Coverage Status](https://coveralls.io/builds/13921430/badge)](https://coveralls.io/builds/13921430)
    
    Coverage remained the same at 98.298% when pulling **61c8ab7878cbe23812be869ea42c74bb9af236c3 on PascalSchumacher:partial_automated_migration_to_assertj** into **6665a02096fc56ad5a60943f65d6f75aea389cf7 on apache:master**.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

[GitHub] commons-text issue #70: partial automated migration to assertj

Posted by coveralls <gi...@git.apache.org>.

Github user coveralls commented on the issue:

    https://github.com/apache/commons-text/pull/70
  
    
    [![Coverage Status](https://coveralls.io/builds/13921641/badge)](https://coveralls.io/builds/13921641)
    
    Coverage remained the same at 98.298% when pulling **34a7dc3345b2b0acd2d91d932e38044b60f14ee7 on PascalSchumacher:partial_automated_migration_to_assertj** into **6665a02096fc56ad5a60943f65d6f75aea389cf7 on apache:master**.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

[GitHub] commons-text issue #70: partial automated migration to assertj

Posted by PascalSchumacher <gi...@git.apache.org>.

Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-text/pull/70
  
    >Cool! Have missed the discussion about introducing this for Text. I like it.
    
    These was no discussion yet. I just thought I do a quick prototype with a component after the general discussion of assertj.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

[GitHub] commons-text issue #70: partial automated migration to assertj

Posted by coveralls <gi...@git.apache.org>.

Github user coveralls commented on the issue:

    https://github.com/apache/commons-text/pull/70
  
    
    [![Coverage Status](https://coveralls.io/builds/13722459/badge)](https://coveralls.io/builds/13722459)
    
    Coverage remained the same at 98.238% when pulling **9fd5bdd5973e64c1fbdce230f21d038c5eee0502 on PascalSchumacher:partial_automated_migration_to_assertj** into **8f7d0494d19a54b1606d0d7779ff4754c3d66b23 on apache:master**.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

[GitHub] commons-text issue #70: partial automated migration to assertj

Posted by britter <gi...@git.apache.org>.

Github user britter commented on the issue:

    https://github.com/apache/commons-text/pull/70
  
    Good idea. It's always better to discuss with some acutal code examples at hands.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

[GitHub] commons-text issue #70: partial automated migration to assertj

Posted by PascalSchumacher <gi...@git.apache.org>.

Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-text/pull/70
  
    Sure. AssertJ 2.x for java 7 and 3.x for java 8 have been developed in parallel for a few years (and currently still are). Java 7 compatible changes are done in 2.x and then merged into 3.x, so 3.x is essentially 2.x plus support for lambdas, predicates and java 8 classes. Migrating for AssertJ 2.x to 3.x is easy, I did it for multiple projects without problems.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

[GitHub] commons-text issue #70: partial automated migration to assertj

Posted by coveralls <gi...@git.apache.org>.

Github user coveralls commented on the issue:

    https://github.com/apache/commons-text/pull/70
  
    
    [![Coverage Status](https://coveralls.io/builds/13916156/badge)](https://coveralls.io/builds/13916156)
    
    Coverage remained the same at 98.298% when pulling **3674f25fe8e239cdaa8fc58cdab9b5b132b42f8c on PascalSchumacher:partial_automated_migration_to_assertj** into **6665a02096fc56ad5a60943f65d6f75aea389cf7 on apache:master**.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org