You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "WillAyd (via GitHub)" <gi...@apache.org> on 2025/03/13 21:14:15 UTC
[PR] GH-45771: [C++] Add tests to top level Meson configuration [arrow]
WillAyd opened a new pull request, #45773:
URL: https://github.com/apache/arrow/pull/45773
### Rationale for this change
This continues adding support to the Meson configuration by adding top level tests that are currently present in CMake
### What changes are included in this PR?
This adds tests and fixes a small bug with the Meson configuration file that generated an incorrect Arrow version
### Are these changes tested?
Yes
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45771: [C++] Add tests to top level Meson configuration [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45773:
URL: https://github.com/apache/arrow/pull/45773#issuecomment-2722706318
:warning: GitHub issue #45771 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45771: [C++] Add tests to top level Meson configuration [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #45773:
URL: https://github.com/apache/arrow/pull/45773#issuecomment-2724736544
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit ab4263476d9d5078cd0fa2cce6b922eb7d90c0af.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/38778446713) has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45771: [C++] Add tests to top level Meson configuration [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #45773:
URL: https://github.com/apache/arrow/pull/45773#issuecomment-2723688687
@github-actions crossbow submit *-meson
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45771: [C++] Add tests to top level Meson configuration [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #45773:
URL: https://github.com/apache/arrow/pull/45773#discussion_r1994963472
##########
cpp/src/arrow/util/meson.build:
##########
@@ -22,7 +22,6 @@ conf_data.set('ARROW_VERSION_MINOR', version_minor)
conf_data.set('ARROW_VERSION_PATCH', version_patch)
conf_data.set('ARROW_VERSION', arrow_version)
-conf_data.set('ARROW_VERSION_STRING', arrow_version)
Review Comment:
Ah, I see!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45771: [C++] Add tests to top level Meson configuration [arrow]
Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on code in PR #45773:
URL: https://github.com/apache/arrow/pull/45773#discussion_r1994954793
##########
cpp/src/arrow/util/meson.build:
##########
@@ -22,7 +22,6 @@ conf_data.set('ARROW_VERSION_MINOR', version_minor)
conf_data.set('ARROW_VERSION_PATCH', version_patch)
conf_data.set('ARROW_VERSION', arrow_version)
-conf_data.set('ARROW_VERSION_STRING', arrow_version)
Review Comment:
This configuration data is unused. In the cmake file, there is a `#define ARROW_VERSION_STRING @ARROW_VERSION@` but nothing for `@ARROW_VERSION_STRING@`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45771: [C++] Add tests to top level Meson configuration [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45773:
URL: https://github.com/apache/arrow/pull/45773#issuecomment-2723692132
Revision: 82fd7c81d0d93fc32a4a5df79df1f1928196a406
Submitted crossbow builds: [ursacomputing/crossbow @ actions-9d579871d8](https://github.com/ursacomputing/crossbow/branches/all?query=actions-9d579871d8)
|Task|Status|
|----|------|
|test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/13850815391/job/38757664144)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45771: [C++] Add tests to top level Meson configuration [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #45773:
URL: https://github.com/apache/arrow/pull/45773#discussion_r1994899602
##########
cpp/src/arrow/util/meson.build:
##########
@@ -22,7 +22,6 @@ conf_data.set('ARROW_VERSION_MINOR', version_minor)
conf_data.set('ARROW_VERSION_PATCH', version_patch)
conf_data.set('ARROW_VERSION', arrow_version)
-conf_data.set('ARROW_VERSION_STRING', arrow_version)
Review Comment:
Why do we need to remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45771: [C++] Add tests to top level Meson configuration [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #45773:
URL: https://github.com/apache/arrow/pull/45773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org