You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2016/09/14 18:35:25 UTC
[GitHub] tinkerpop pull request #416: TINKERPOP-1449 Streamline gremlin-python build
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/416
TINKERPOP-1449 Streamline gremlin-python build
https://issues.apache.org/jira/browse/TINKERPOP-1449
I'm really happy with this PR. Cleaned up a lot of weird/inconsistent things in the gremlin-python build. Most importantly, I got rid of `-DglvPython` - which I somehow manage to forget to include on more occasions that i care to admit to. The solution is pretty simple - if you have an environment setup to build gremlin-python then you add a `.glv` file to the root of `gremlin-python` (hidden from git). If maven sees that file, it knows that it's OK to activate the profile that builds it.
You can still obviously do:
```text
mvn clean install -pl gremlin-server -Pglv-python
```
which directly activates the profile by its name.
Also note that I bumped to the latest version of the gmavenplus-plugin and centralized its configuration in the parent pom.xml.
All docs are updated to reflect the change to how `gremlin-python` is now built. Tests all seem to run ok. I even did a manual test to deploy python artifacts to pypitest and it worked nicely with:
```text
mvn clean deploy -pl gremlin-python -Dpypi -DskipTests
```
VOTE: +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1449
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/416.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #416
----
commit fdd70e5edfb0743114a1825b025e3c0e1124d098
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-09-14T15:35:56Z
Removed the second jython execution from gremlin-python build
commit e0d7c90d4391e24ae18fdb2cc6a57c978039b29f
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-09-14T15:59:07Z
Drop -DglvPython as a requirement for building gremlin-python.
Now you can just add .glv file to the root of gremlin-python to let Maven know that your environment is python-enabled.
commit 2fbeb596d7fe72bccaf2d5a3e5eac0344882a3b1
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-09-14T16:01:37Z
Updated changelog about -DglvPython
commit 2106b10e74008481b19bba98635f65dda99800bf
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-09-14T16:16:13Z
Allow -DskipTests to still produce a valid build of gremlin-python
commit 9b4c7884dc5c3e09086113b3720f07e1501951c4
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-09-14T17:45:41Z
Centrally manage gmavenplus plugin and bump to 1.5
commit 079cc20d9604c7bcbf21496a6fc042374f86b282
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-09-14T18:14:20Z
Udpated dev docs related to release given changes to gremlin-python build
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #416: TINKERPOP-1449 Streamline gremlin-python build
Posted by davebshow <gi...@git.apache.org>.
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/416
Worked like a charm. Vote +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #416: TINKERPOP-1449 Streamline gremlin-python build
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/416
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---