[GitHub] [mina-sshd] tomaswolf commented on pull request #198: SSHD-1166 - Support creating signed OpenSSH Certificates

[GitBox <gi...@apache.org>]

tomaswolf commented on pull request #198:
URL: https://github.com/apache/mina-sshd/pull/198#issuecomment-873227084


   In the `GenerateOpenSSHClientCertificateTest` the generated certificate apparently always uses rsa-sha2-512 for signing with RSA CA keys. Does the `OpenSshCertificateBuilder` need another setter `setAlgorithm(String algorithm)` to be able to specify exactly which signature should be generated? ("ssh-rsa", "rsa-sha2-256", or "rsa-sha2-512".)
   
   One would have to verify that the algorithm set through this setter, if any, was compatible with the CA key type at all.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org