You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/03/11 08:37:04 UTC
[GitHub] [rocketmq] Rookiexu opened a new pull request #1835: Simplify the
code
Rookiexu opened a new pull request #1835: Simplify the code
URL: https://github.com/apache/rocketmq/pull/1835
## What is the purpose of the change
Extract the code block copied three times into a separate method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] vongosling merged pull request #1835: [ISSUE #1857]
Refactor the duplicated code
Posted by GitBox <gi...@apache.org>.
vongosling merged pull request #1835: [ISSUE #1857] Refactor the duplicated code
URL: https://github.com/apache/rocketmq/pull/1835
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] Rookiexu commented on issue #1835: Refactor the
duplicated code
Posted by GitBox <gi...@apache.org>.
Rookiexu commented on issue #1835: Refactor the duplicated code
URL: https://github.com/apache/rocketmq/pull/1835#issuecomment-599422420
> @Rookiexu Thanks for your refactoring. It would be better to open an issue before you summit a pr.
OK,i agree with you.This is my issue [issue1857](https://github.com/apache/rocketmq/issues/1857)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] Rookiexu edited a comment on issue #1835: Refactor the
duplicated code
Posted by GitBox <gi...@apache.org>.
Rookiexu edited a comment on issue #1835: Refactor the duplicated code
URL: https://github.com/apache/rocketmq/pull/1835#issuecomment-599422420
> @Rookiexu Thanks for your refactoring. It would be better to open an issue before you summit a pr.
@vongosling OK,i agree with you.This is my issue [issue1857](https://github.com/apache/rocketmq/issues/1857)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] vongosling commented on issue #1835: Refactor the
duplicated code
Posted by GitBox <gi...@apache.org>.
vongosling commented on issue #1835: Refactor the duplicated code
URL: https://github.com/apache/rocketmq/pull/1835#issuecomment-599375900
@Rookiexu Thanks for your refactoring. It would be better to open an issue before you summit a pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services