[GitHub] [logging-log4cxx] ams-tschoening commented on pull request #54: [Logcxx-515] Add fmt support

[GitBox <gi...@apache.org>]

ams-tschoening commented on pull request #54:
URL: https://github.com/apache/logging-log4cxx/pull/54#issuecomment-803595060


   I get the following warning in Visual Studio when building everything:
   
   ```
   CMake Warning at src/examples/cpp/CMakeLists.txt:15 (find_package):
     By not providing "Findfmt.cmake" in CMAKE_MODULE_PATH this project has
     asked CMake to find a package configuration file provided by "fmt", but
     CMake did not find one.
   
     Could not find a package configuration file provided by "fmt" with any of
     the following names:
   
       fmtConfig.cmake
       fmt-config.cmake
   
     Add the installation prefix of "fmt" to CMAKE_PREFIX_PATH or set "fmt_DIR"
     to a directory containing one of the above files.  If "fmt" provides a
     separate development package or SDK, be sure it has been installed.
   ```
   
   As I'm somewhat new to CMAKE, that made me wonder. Does it make sense to document that such a warning can simply be ignored in the CMAKE-file and/or the newly added docs?  Something like the following?
   
   ```
   # Custom handling for format string example, since it utilizes "libfmt". Without that lib being
   # provided, a warning is logged by CMAKE, which can easily be ignored. Things are NOT build without
   # that lib and CMAKE is simply telling one that.
   ```
   
   And/or:
   
   ```
   A full example can be seen in the "src/examples/cpp/format-string.cpp" file. Attention: Without 
   "libfmt" being available, CMAKE might log a warning telling one exactly that and NOT building the
   example. So that warning can simply be ignored.
   ```
   
   Or should we make looking for that package simply [silent](https://cmake.org/cmake/help/latest/command/find_package.html)?
   
   ```
   find_package(fmt QUIET)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org