You are viewing a plain text version of this content. The canonical link for it is here.

Posted to discuss-archive@tvm.apache.org by Manupa Karunaratne via Apache TVM Discuss <no...@discuss.tvm.ai> on 2020/11/23 15:05:08 UTC

[Apache TVM Discuss] [Questions] [CI] C++ standard for the TVM project


Are we using c++ std14 or std17 for the tvm project ?
From what I can tell, it looks like std14. 

If so, is the CI expected to fail on C++17 only features ?

cc : @tqchen





---
[Visit Topic](https://discuss.tvm.apache.org/t/ci-c-standard-for-the-tvm-project/8508/1) to respond.

You are receiving this because you enabled mailing list mode.

To unsubscribe from these emails, [click here](https://discuss.tvm.apache.org/email/unsubscribe/1914c910a3233988eb59a5b2730b4af481c76afa0a3d71ab16e8d7c52c42231a).

[Apache TVM Discuss] [Questions] [CI] C++ standard for the TVM project

Posted by Manupa Karunaratne via Apache TVM Discuss <no...@discuss.tvm.ai>.


https://github.com/apache/tvm/pull/6968/files





---
[Visit Topic](https://discuss.tvm.apache.org/t/ci-c-standard-for-the-tvm-project/8508/5) to respond.

You are receiving this because you enabled mailing list mode.

To unsubscribe from these emails, [click here](https://discuss.tvm.apache.org/email/unsubscribe/0652b727db7bbe86dcd94ee54d1c33f508e5b137801a490460b07d7ceba4ba64).

[Apache TVM Discuss] [Questions] [CI] C++ standard for the TVM project

Posted by tqchen via Apache TVM Discuss <no...@discuss.tvm.ai>.


This is certainly interesting. I think the behavior depends on the debug/release and whether the symbol is inlined. This is indeed a problem that we can see in a few places. The simplest thing is to re-assign a local var before use





---
[Visit Topic](https://discuss.tvm.apache.org/t/ci-c-standard-for-the-tvm-project/8508/4) to respond.

You are receiving this because you enabled mailing list mode.

To unsubscribe from these emails, [click here](https://discuss.tvm.apache.org/email/unsubscribe/8745b9ae66097ea15a669b5b783df228d9a4a7ba91e53da35ac12ddac2b9bded).

[Apache TVM Discuss] [Questions] [CI] C++ standard for the TVM project

Posted by Manupa Karunaratne via Apache TVM Discuss <no...@discuss.tvm.ai>.


So if you look at : https://github.com/apache/incubator-tvm/blob/main/src/runtime/micro/micro_session.cc

You can see that there is a  : static constexpr const size_t kReceiveBufferSizeBytes = 128;
which is declared but not defined and used directly below as an argument which leads to linking failure in our dev. environment in < c++17 ( in C++17, I believe it does an inline directly). 

However, the tvm upstream CI does not see this issue and Im quite puzzled how it only gives the error in my local dev. environment when built with USE_MICRO. While the fix is trivial, I was looking how this escapes CI.





---
[Visit Topic](https://discuss.tvm.apache.org/t/ci-c-standard-for-the-tvm-project/8508/3) to respond.

You are receiving this because you enabled mailing list mode.

To unsubscribe from these emails, [click here](https://discuss.tvm.apache.org/email/unsubscribe/24f84cacfdad7b1d142f02f9dc51f207e5e7c1416c73140673b13a97b7ec43df).

[Apache TVM Discuss] [Questions] [CI] C++ standard for the TVM project

Posted by tqchen via Apache TVM Discuss <no...@discuss.tvm.ai>.


I think so, we only compile with std=c++14, so it should fail on new things that are in c++17





---
[Visit Topic](https://discuss.tvm.apache.org/t/ci-c-standard-for-the-tvm-project/8508/2) to respond.

You are receiving this because you enabled mailing list mode.

To unsubscribe from these emails, [click here](https://discuss.tvm.apache.org/email/unsubscribe/186f1e483778a8c1cab293cc6010342f7d9e4e25a24003ac3856437d88ce03bd).