You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/03/10 18:14:28 UTC
[GitHub] [beam] y1chi commented on a change in pull request #14179: [BEAM-11949] Remove custom window fn and window type checks in dataflow runner
y1chi commented on a change in pull request #14179:
URL: https://github.com/apache/beam/pull/14179#discussion_r591757405
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -394,7 +395,7 @@ def _check_for_unsupported_fnapi_features(self, pipeline_proto):
if (windowing_strategy.merge_status ==
beam_runner_api_pb2.MergeStatus.NEEDS_MERGE and
windowing_strategy.window_fn.urn not in (
- common_urns.session_windows.urn, )):
+ common_urns.session_windows.urn, python_urns.PICKLED_WINDOWFN)):
raise RuntimeError(
'Unsupported merging windowing strategy: %s' %
windowing_strategy.window_fn.urn)
Review comment:
done.
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -394,7 +395,7 @@ def _check_for_unsupported_fnapi_features(self, pipeline_proto):
if (windowing_strategy.merge_status ==
beam_runner_api_pb2.MergeStatus.NEEDS_MERGE and
windowing_strategy.window_fn.urn not in (
- common_urns.session_windows.urn, )):
+ common_urns.session_windows.urn, python_urns.PICKLED_WINDOWFN)):
Review comment:
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org