[GitHub] [airflow] shivanshs9 commented on a change in pull request #10987: Fix: add support for no-menu plugin views (#10788)

[GitBox <gi...@apache.org>]

shivanshs9 commented on a change in pull request #10987:
URL: https://github.com/apache/airflow/pull/10987#discussion_r509895817



##########
File path: airflow/www/extensions/init_views.py
##########
@@ -73,8 +73,12 @@ def init_plugins(app):
     appbuilder = app.appbuilder
 
     for view in plugins_manager.flask_appbuilder_views:
-        log.debug("Adding view %s", view["name"])
-        appbuilder.add_view(view["view"], view["name"], category=view["category"])
+        try:
+            log.debug("Adding view %s with menu", view["name"])
+            appbuilder.add_view(view["view"], view["name"], category=view["category"])
+        except KeyError:

Review comment:
       @mik-laj got it! 👍🏻
   I didn't use if-else paradigm to check the key since it is against the python's EAFP principle. I can still check against the missing key which threw error though, in the catch block so will add that asap.
   
   I've been setting up test environment too and will add the required tests asap. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org