[GitHub] [shardingsphere] azexcy commented on a diff in pull request #25055: Improve inventory task dumper at pipeline

["azexcy (via GitHub)" <gi...@apache.org>]

azexcy commented on code in PR #25055:
URL: https://github.com/apache/shardingsphere/pull/25055#discussion_r1161189071


##########
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/task/InventoryIncrementalTasksRunner.java:
##########
@@ -49,6 +49,7 @@ public class InventoryIncrementalTasksRunner implements PipelineTasksRunner {
     
     private final Collection<IncrementalTask> incrementalTasks;
     
+    @Getter
     private final PipelineJobAPI jobAPI;

Review Comment:
   Maybe subclass only have inventory task, then it's will use jobAPI methods, just like `stop()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org