You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@bahir.apache.org by GitBox <gi...@apache.org> on 2019/02/05 14:15:22 UTC

[GitHub] eskabetxe commented on issue #42: Enhanced create RpcClient and FlumeSink

eskabetxe commented on issue #42: Enhanced create RpcClient and FlumeSink
URL: https://github.com/apache/bahir-flink/pull/42#issuecomment-460652537
 
 
   thanks for the PR, its a great improvement of flume connector.
   but, why have you created a new sink instead of improving the existing one?
   mainly because the existing one is very basic and easily adaptable to your version

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services