[jira] Updated: (DERBY-4070) Embedded and client data sources throw different exception when a connection attribute is badly formatted

["Kristian Waagan (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DERBY-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-4070:
-----------------------------------

    Attachment: derby-4070-1b-ds_exception_handling.diff

Attached updated patch 1b, which checks if the connection attributes are null. We don't want to add "<null>" to the URL.
I'm not sure if  "<protocol><databasename>[;<connectionAttributes>]" is enough for the URL.
What about the other properties, like Ssl or securityMechanism, which can be specified both by connectionAttributes and the specific setter methods?
At the moment the constructed URL is only used for the error message.

I think the issue connectionAttributes vs setter method is something we should define guidelines for.
Which takes precedence?
Should using the connectionAttributes be disallowed for properties that have a setter?

> Embedded and client data sources throw different exception when a connection attribute is badly formatted
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-4070
>                 URL: https://issues.apache.org/jira/browse/DERBY-4070
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.2.1, 10.5.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-4070-1a-ds_exception_handling.diff, derby-4070-1b-ds_exception_handling.diff
>
>
> If a connection attribute is badly formatted, for instance if the attribute name is specified without a corresponding value, the embedded and the client data sources throw different exceptions:
>   o XJ212: Invalid attribute syntax: bad
>   o XJ028: The URL 'jdbc:derby://localhost:1527/wombat;bad' is not properly formed.
> Currently the only client data source affected is ClientDataSource, but the connection pool and XA data sources also have to deal with this issue when DERBY-4067 has been fixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.