You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by Davide Giannella <da...@apache.org> on 2014/10/28 09:32:59 UTC

Re: svn commit: r1634774 - in /jackrabbit/oak/trunk/oak-lucene/src: main/java/org/apache/jackrabbit/oak/plugins/index/lucene/ test/java/org/apache/jackrabbit/oak/plugins/index/lucene/

On 28/10/2014 03:23, amitj@apache.org wrote:
> Author: amitj
> Date: Tue Oct 28 03:23:45 2014
> New Revision: 1634774
>
> URL: http://svn.apache.org/r1634774
> Log:
> OAK-2200: Tune cost calculation for lucene property index
> Added a configurable param entryCount which defaults to 1000 and indicates the max count to be returned by the lucene index.
>
Doesn't `entryCount` for other indexes means the value actually
returned? If so it would be clearer to keep the same behaviour and in
case the "max count returned" is needed introduce a new variable;
something like maxEntryCount.

D.



Re: svn commit: r1634774 - in /jackrabbit/oak/trunk/oak-lucene/src: main/java/org/apache/jackrabbit/oak/plugins/index/lucene/ test/java/org/apache/jackrabbit/oak/plugins/index/lucene/

Posted by Thomas Mueller <mu...@adobe.com>.
Hi,

I think using "entryCount" is ok. It's anyway only needed until we have
proper cost estimation in the property index and ordered index.

Regards,
Thomas



On 28/10/14 09:32, "Davide Giannella" <da...@apache.org> wrote:

>On 28/10/2014 03:23, amitj@apache.org wrote:
>> Author: amitj
>> Date: Tue Oct 28 03:23:45 2014
>> New Revision: 1634774
>>
>> URL: http://svn.apache.org/r1634774
>> Log:
>> OAK-2200: Tune cost calculation for lucene property index
>> Added a configurable param entryCount which defaults to 1000 and
>>indicates the max count to be returned by the lucene index.
>>
>Doesn't `entryCount` for other indexes means the value actually
>returned? If so it would be clearer to keep the same behaviour and in
>case the "max count returned" is needed introduce a new variable;
>something like maxEntryCount.
>
>D.
>
>