You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Neville Dipale (JIRA)" <ji...@apache.org> on 2019/03/13 19:30:00 UTC

[jira] [Commented] (ARROW-4854) [Rust] Use Array Slice for limit kernel

    [ https://issues.apache.org/jira/browse/ARROW-4854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792047#comment-16792047 ] 

Neville Dipale commented on ARROW-4854:
---------------------------------------

Note to whomever implements this, it's better to not conditionally check the data type and limit/slice based on it. We can wait for ARROW-4853 then implement a single slice function:
{code:java}
pub fn limit(array: &ArrayRef, num_elements: usize) -> Result<ArrayRef> {
Ok(array.slice(9, num_elements))
}
{code}

> [Rust] Use Array Slice for limit kernel
> ---------------------------------------
>
>                 Key: ARROW-4854
>                 URL: https://issues.apache.org/jira/browse/ARROW-4854
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Rust
>    Affects Versions: 0.13.0
>            Reporter: Neville Dipale
>            Priority: Minor
>
> We currently reconstruct an array when taking a limit from it, we can improve performance by using slice from ARROW-3954



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)