You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/08/07 01:48:08 UTC
[GitHub] [commons-lang] greatmastermario opened a new pull request #785: LANG-1663: Update documentation to list correct exception for null array parameters
greatmastermario opened a new pull request #785:
URL: https://github.com/apache/commons-lang/pull/785
Updated documentation in NumberUtils to correctly state that a NullPointerException is thrown when the array is null, not an IllegalArgumentException.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] greatmastermario commented on pull request #785: LANG-1663: Update documentation to list correct exception for null array parameters
Posted by GitBox <gi...@apache.org>.
greatmastermario commented on pull request #785:
URL: https://github.com/apache/commons-lang/pull/785#issuecomment-894667374
I went to go write some test cases, and it looks like there are already test cases that use assertThrows with the correct NullPointerException. So we already have the test coverage, it just didn't reflect in the Javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls commented on pull request #785: LANG-1663: Update documentation to list correct exception for null array parameters
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #785:
URL: https://github.com/apache/commons-lang/pull/785#issuecomment-894588885
[](https://coveralls.io/builds/41975704)
Coverage remained the same at 94.995% when pulling **499fcac59d2ef24751d401039ff952e3ccef7b29 on greatmastermario:LANG-1663-Wrong-Exception-Docs** into **7c658527094083b2037d362916adf8eb2493ea65 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory merged pull request #785: LANG-1663: Update documentation to list correct exception for null array parameters
Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #785:
URL: https://github.com/apache/commons-lang/pull/785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #785: LANG-1663: Update documentation to list correct exception for null array parameters
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #785:
URL: https://github.com/apache/commons-lang/pull/785#issuecomment-901905417
May you please rebase on master to pick up the recent Java 16 fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #785: LANG-1663: Update documentation to list correct exception for null array parameters
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #785:
URL: https://github.com/apache/commons-lang/pull/785#issuecomment-894588885
[](https://coveralls.io/builds/42272655)
Coverage remained the same at 94.985% when pulling **ba577cacc5355c830a013e73c431a8382ee717a7 on greatmastermario:LANG-1663-Wrong-Exception-Docs** into **ce477d9140f1439c44c7a852d7df1e069e21cb85 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] HubertWo commented on pull request #785: LANG-1663: Update documentation to list correct exception for null array parameters
Posted by GitBox <gi...@apache.org>.
HubertWo commented on pull request #785:
URL: https://github.com/apache/commons-lang/pull/785#issuecomment-894618605
Regarding Javadoc - good catch! :)
Did you consider to add assertThrows in tests for these methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] greatmastermario edited a comment on pull request #785: LANG-1663: Update documentation to list correct exception for null array parameters
Posted by GitBox <gi...@apache.org>.
greatmastermario edited a comment on pull request #785:
URL: https://github.com/apache/commons-lang/pull/785#issuecomment-894667374
I went to go write some test cases, and it looks like there are already test cases that use assertThrows with the correct NullPointerException. So we already have the test coverage, it just didn't reflect in the Javadoc. See NumberUtilsTest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #785: LANG-1663: Update documentation to list correct exception for null array parameters
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #785:
URL: https://github.com/apache/commons-lang/pull/785#issuecomment-894588885
[](https://coveralls.io/builds/42257171)
Coverage remained the same at 94.984% when pulling **9ca4915ddcf58220cff7dc5528fd9e7aacbaf39a on greatmastermario:LANG-1663-Wrong-Exception-Docs** into **a6df7f74564b9432bf38fe33c4adc0bc529bf7c9 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org