You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/12/14 05:25:25 UTC

[GitHub] [iotdb] HTHou commented on a change in pull request #2263: Move memtable plan index from ChunkGroupFooter to a separate marker

HTHou commented on a change in pull request #2263:
URL: https://github.com/apache/iotdb/pull/2263#discussion_r542120044



##########
File path: tsfile/src/main/java/org/apache/iotdb/tsfile/file/MetaMarker.java
##########
@@ -30,6 +30,10 @@
   public static final byte CHUNK_HEADER = 1;
   public static final byte SEPARATOR = 2;
   public static final byte VERSION = 3;
+  // following this marker are two longs marking the minimum and maximum indices of operations
+  // involved in the last flushed MemTable, which are generally used to support checkpoint,
+  // snapshot, or backup.
+  public static final byte OPERATION_INDEX_RANGE = 4;

Review comment:
       Actually in the new tsfile,  we use number 4 as another type of chunk_header. 
   https://cwiki.apache.org/confluence/display/IOTDB/New+TsFile+Format
   What about change this to 5, or change the new chunk_header marker to 5?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org