You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by ch...@apache.org on 2018/01/31 13:26:04 UTC
[2/5] flink git commit: [FLINK-8422] [core] Checkstyle for
org.apache.flink.api.java.tuple
http://git-wip-us.apache.org/repos/asf/flink/blob/36b2325a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple20Builder.java
----------------------------------------------------------------------
diff --git a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple20Builder.java b/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple20Builder.java
index 5d08c0d..6e54b8a 100644
--- a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple20Builder.java
+++ b/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple20Builder.java
@@ -16,21 +16,43 @@
* limitations under the License.
*/
-
// --------------------------------------------------------------
// THIS IS A GENERATED SOURCE FILE. DO NOT EDIT!
// GENERATED FROM org.apache.flink.api.java.tuple.TupleGenerator.
// --------------------------------------------------------------
-
package org.apache.flink.api.java.tuple.builder;
-import java.util.ArrayList;
-import java.util.List;
-
import org.apache.flink.annotation.Public;
import org.apache.flink.api.java.tuple.Tuple20;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * A builder class for {@link Tuple20}.
+ *
+ * @param <T0> The type of field 0
+ * @param <T1> The type of field 1
+ * @param <T2> The type of field 2
+ * @param <T3> The type of field 3
+ * @param <T4> The type of field 4
+ * @param <T5> The type of field 5
+ * @param <T6> The type of field 6
+ * @param <T7> The type of field 7
+ * @param <T8> The type of field 8
+ * @param <T9> The type of field 9
+ * @param <T10> The type of field 10
+ * @param <T11> The type of field 11
+ * @param <T12> The type of field 12
+ * @param <T13> The type of field 13
+ * @param <T14> The type of field 14
+ * @param <T15> The type of field 15
+ * @param <T16> The type of field 16
+ * @param <T17> The type of field 17
+ * @param <T18> The type of field 18
+ * @param <T19> The type of field 19
+ */
@Public
public class Tuple20Builder<T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15, T16, T17, T18, T19> {
http://git-wip-us.apache.org/repos/asf/flink/blob/36b2325a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple21Builder.java
----------------------------------------------------------------------
diff --git a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple21Builder.java b/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple21Builder.java
index cdcf806..af1a55e 100644
--- a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple21Builder.java
+++ b/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple21Builder.java
@@ -16,21 +16,44 @@
* limitations under the License.
*/
-
// --------------------------------------------------------------
// THIS IS A GENERATED SOURCE FILE. DO NOT EDIT!
// GENERATED FROM org.apache.flink.api.java.tuple.TupleGenerator.
// --------------------------------------------------------------
-
package org.apache.flink.api.java.tuple.builder;
-import java.util.ArrayList;
-import java.util.List;
-
import org.apache.flink.annotation.Public;
import org.apache.flink.api.java.tuple.Tuple21;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * A builder class for {@link Tuple21}.
+ *
+ * @param <T0> The type of field 0
+ * @param <T1> The type of field 1
+ * @param <T2> The type of field 2
+ * @param <T3> The type of field 3
+ * @param <T4> The type of field 4
+ * @param <T5> The type of field 5
+ * @param <T6> The type of field 6
+ * @param <T7> The type of field 7
+ * @param <T8> The type of field 8
+ * @param <T9> The type of field 9
+ * @param <T10> The type of field 10
+ * @param <T11> The type of field 11
+ * @param <T12> The type of field 12
+ * @param <T13> The type of field 13
+ * @param <T14> The type of field 14
+ * @param <T15> The type of field 15
+ * @param <T16> The type of field 16
+ * @param <T17> The type of field 17
+ * @param <T18> The type of field 18
+ * @param <T19> The type of field 19
+ * @param <T20> The type of field 20
+ */
@Public
public class Tuple21Builder<T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15, T16, T17, T18, T19, T20> {
http://git-wip-us.apache.org/repos/asf/flink/blob/36b2325a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple22Builder.java
----------------------------------------------------------------------
diff --git a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple22Builder.java b/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple22Builder.java
index 1745940..b0070c6 100644
--- a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple22Builder.java
+++ b/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple22Builder.java
@@ -16,21 +16,45 @@
* limitations under the License.
*/
-
// --------------------------------------------------------------
// THIS IS A GENERATED SOURCE FILE. DO NOT EDIT!
// GENERATED FROM org.apache.flink.api.java.tuple.TupleGenerator.
// --------------------------------------------------------------
-
package org.apache.flink.api.java.tuple.builder;
-import java.util.ArrayList;
-import java.util.List;
-
import org.apache.flink.annotation.Public;
import org.apache.flink.api.java.tuple.Tuple22;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * A builder class for {@link Tuple22}.
+ *
+ * @param <T0> The type of field 0
+ * @param <T1> The type of field 1
+ * @param <T2> The type of field 2
+ * @param <T3> The type of field 3
+ * @param <T4> The type of field 4
+ * @param <T5> The type of field 5
+ * @param <T6> The type of field 6
+ * @param <T7> The type of field 7
+ * @param <T8> The type of field 8
+ * @param <T9> The type of field 9
+ * @param <T10> The type of field 10
+ * @param <T11> The type of field 11
+ * @param <T12> The type of field 12
+ * @param <T13> The type of field 13
+ * @param <T14> The type of field 14
+ * @param <T15> The type of field 15
+ * @param <T16> The type of field 16
+ * @param <T17> The type of field 17
+ * @param <T18> The type of field 18
+ * @param <T19> The type of field 19
+ * @param <T20> The type of field 20
+ * @param <T21> The type of field 21
+ */
@Public
public class Tuple22Builder<T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15, T16, T17, T18, T19, T20, T21> {
http://git-wip-us.apache.org/repos/asf/flink/blob/36b2325a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple23Builder.java
----------------------------------------------------------------------
diff --git a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple23Builder.java b/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple23Builder.java
index 75e554d..19a406a 100644
--- a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple23Builder.java
+++ b/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple23Builder.java
@@ -16,21 +16,46 @@
* limitations under the License.
*/
-
// --------------------------------------------------------------
// THIS IS A GENERATED SOURCE FILE. DO NOT EDIT!
// GENERATED FROM org.apache.flink.api.java.tuple.TupleGenerator.
// --------------------------------------------------------------
-
package org.apache.flink.api.java.tuple.builder;
-import java.util.ArrayList;
-import java.util.List;
-
import org.apache.flink.annotation.Public;
import org.apache.flink.api.java.tuple.Tuple23;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * A builder class for {@link Tuple23}.
+ *
+ * @param <T0> The type of field 0
+ * @param <T1> The type of field 1
+ * @param <T2> The type of field 2
+ * @param <T3> The type of field 3
+ * @param <T4> The type of field 4
+ * @param <T5> The type of field 5
+ * @param <T6> The type of field 6
+ * @param <T7> The type of field 7
+ * @param <T8> The type of field 8
+ * @param <T9> The type of field 9
+ * @param <T10> The type of field 10
+ * @param <T11> The type of field 11
+ * @param <T12> The type of field 12
+ * @param <T13> The type of field 13
+ * @param <T14> The type of field 14
+ * @param <T15> The type of field 15
+ * @param <T16> The type of field 16
+ * @param <T17> The type of field 17
+ * @param <T18> The type of field 18
+ * @param <T19> The type of field 19
+ * @param <T20> The type of field 20
+ * @param <T21> The type of field 21
+ * @param <T22> The type of field 22
+ */
@Public
public class Tuple23Builder<T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15, T16, T17, T18, T19, T20, T21, T22> {
http://git-wip-us.apache.org/repos/asf/flink/blob/36b2325a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple24Builder.java
----------------------------------------------------------------------
diff --git a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple24Builder.java b/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple24Builder.java
index d89e6be..172ee1b 100644
--- a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple24Builder.java
+++ b/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple24Builder.java
@@ -16,21 +16,47 @@
* limitations under the License.
*/
-
// --------------------------------------------------------------
// THIS IS A GENERATED SOURCE FILE. DO NOT EDIT!
// GENERATED FROM org.apache.flink.api.java.tuple.TupleGenerator.
// --------------------------------------------------------------
-
package org.apache.flink.api.java.tuple.builder;
-import java.util.ArrayList;
-import java.util.List;
-
import org.apache.flink.annotation.Public;
import org.apache.flink.api.java.tuple.Tuple24;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * A builder class for {@link Tuple24}.
+ *
+ * @param <T0> The type of field 0
+ * @param <T1> The type of field 1
+ * @param <T2> The type of field 2
+ * @param <T3> The type of field 3
+ * @param <T4> The type of field 4
+ * @param <T5> The type of field 5
+ * @param <T6> The type of field 6
+ * @param <T7> The type of field 7
+ * @param <T8> The type of field 8
+ * @param <T9> The type of field 9
+ * @param <T10> The type of field 10
+ * @param <T11> The type of field 11
+ * @param <T12> The type of field 12
+ * @param <T13> The type of field 13
+ * @param <T14> The type of field 14
+ * @param <T15> The type of field 15
+ * @param <T16> The type of field 16
+ * @param <T17> The type of field 17
+ * @param <T18> The type of field 18
+ * @param <T19> The type of field 19
+ * @param <T20> The type of field 20
+ * @param <T21> The type of field 21
+ * @param <T22> The type of field 22
+ * @param <T23> The type of field 23
+ */
@Public
public class Tuple24Builder<T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15, T16, T17, T18, T19, T20, T21, T22, T23> {
http://git-wip-us.apache.org/repos/asf/flink/blob/36b2325a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple25Builder.java
----------------------------------------------------------------------
diff --git a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple25Builder.java b/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple25Builder.java
index a1b8ad7..7f6bdae 100644
--- a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple25Builder.java
+++ b/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple25Builder.java
@@ -16,21 +16,48 @@
* limitations under the License.
*/
-
// --------------------------------------------------------------
// THIS IS A GENERATED SOURCE FILE. DO NOT EDIT!
// GENERATED FROM org.apache.flink.api.java.tuple.TupleGenerator.
// --------------------------------------------------------------
-
package org.apache.flink.api.java.tuple.builder;
-import java.util.ArrayList;
-import java.util.List;
-
import org.apache.flink.annotation.Public;
import org.apache.flink.api.java.tuple.Tuple25;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * A builder class for {@link Tuple25}.
+ *
+ * @param <T0> The type of field 0
+ * @param <T1> The type of field 1
+ * @param <T2> The type of field 2
+ * @param <T3> The type of field 3
+ * @param <T4> The type of field 4
+ * @param <T5> The type of field 5
+ * @param <T6> The type of field 6
+ * @param <T7> The type of field 7
+ * @param <T8> The type of field 8
+ * @param <T9> The type of field 9
+ * @param <T10> The type of field 10
+ * @param <T11> The type of field 11
+ * @param <T12> The type of field 12
+ * @param <T13> The type of field 13
+ * @param <T14> The type of field 14
+ * @param <T15> The type of field 15
+ * @param <T16> The type of field 16
+ * @param <T17> The type of field 17
+ * @param <T18> The type of field 18
+ * @param <T19> The type of field 19
+ * @param <T20> The type of field 20
+ * @param <T21> The type of field 21
+ * @param <T22> The type of field 22
+ * @param <T23> The type of field 23
+ * @param <T24> The type of field 24
+ */
@Public
public class Tuple25Builder<T0, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15, T16, T17, T18, T19, T20, T21, T22, T23, T24> {
http://git-wip-us.apache.org/repos/asf/flink/blob/36b2325a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple2Builder.java
----------------------------------------------------------------------
diff --git a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple2Builder.java b/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple2Builder.java
index 5631218..8ee5d15 100644
--- a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple2Builder.java
+++ b/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple2Builder.java
@@ -16,21 +16,25 @@
* limitations under the License.
*/
-
// --------------------------------------------------------------
// THIS IS A GENERATED SOURCE FILE. DO NOT EDIT!
// GENERATED FROM org.apache.flink.api.java.tuple.TupleGenerator.
// --------------------------------------------------------------
-
package org.apache.flink.api.java.tuple.builder;
-import java.util.ArrayList;
-import java.util.List;
-
import org.apache.flink.annotation.Public;
import org.apache.flink.api.java.tuple.Tuple2;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * A builder class for {@link Tuple2}.
+ *
+ * @param <T0> The type of field 0
+ * @param <T1> The type of field 1
+ */
@Public
public class Tuple2Builder<T0, T1> {
http://git-wip-us.apache.org/repos/asf/flink/blob/36b2325a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple3Builder.java
----------------------------------------------------------------------
diff --git a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple3Builder.java b/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple3Builder.java
index 988e526..79b586a 100644
--- a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple3Builder.java
+++ b/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple3Builder.java
@@ -16,21 +16,26 @@
* limitations under the License.
*/
-
// --------------------------------------------------------------
// THIS IS A GENERATED SOURCE FILE. DO NOT EDIT!
// GENERATED FROM org.apache.flink.api.java.tuple.TupleGenerator.
// --------------------------------------------------------------
-
package org.apache.flink.api.java.tuple.builder;
-import java.util.ArrayList;
-import java.util.List;
-
import org.apache.flink.annotation.Public;
import org.apache.flink.api.java.tuple.Tuple3;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * A builder class for {@link Tuple3}.
+ *
+ * @param <T0> The type of field 0
+ * @param <T1> The type of field 1
+ * @param <T2> The type of field 2
+ */
@Public
public class Tuple3Builder<T0, T1, T2> {
http://git-wip-us.apache.org/repos/asf/flink/blob/36b2325a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple4Builder.java
----------------------------------------------------------------------
diff --git a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple4Builder.java b/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple4Builder.java
index 7151115..188e7ce 100644
--- a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple4Builder.java
+++ b/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple4Builder.java
@@ -16,21 +16,27 @@
* limitations under the License.
*/
-
// --------------------------------------------------------------
// THIS IS A GENERATED SOURCE FILE. DO NOT EDIT!
// GENERATED FROM org.apache.flink.api.java.tuple.TupleGenerator.
// --------------------------------------------------------------
-
package org.apache.flink.api.java.tuple.builder;
-import java.util.ArrayList;
-import java.util.List;
-
import org.apache.flink.annotation.Public;
import org.apache.flink.api.java.tuple.Tuple4;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * A builder class for {@link Tuple4}.
+ *
+ * @param <T0> The type of field 0
+ * @param <T1> The type of field 1
+ * @param <T2> The type of field 2
+ * @param <T3> The type of field 3
+ */
@Public
public class Tuple4Builder<T0, T1, T2, T3> {
http://git-wip-us.apache.org/repos/asf/flink/blob/36b2325a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple5Builder.java
----------------------------------------------------------------------
diff --git a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple5Builder.java b/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple5Builder.java
index 2a05518..70a6877 100644
--- a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple5Builder.java
+++ b/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple5Builder.java
@@ -16,21 +16,28 @@
* limitations under the License.
*/
-
// --------------------------------------------------------------
// THIS IS A GENERATED SOURCE FILE. DO NOT EDIT!
// GENERATED FROM org.apache.flink.api.java.tuple.TupleGenerator.
// --------------------------------------------------------------
-
package org.apache.flink.api.java.tuple.builder;
-import java.util.ArrayList;
-import java.util.List;
-
import org.apache.flink.annotation.Public;
import org.apache.flink.api.java.tuple.Tuple5;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * A builder class for {@link Tuple5}.
+ *
+ * @param <T0> The type of field 0
+ * @param <T1> The type of field 1
+ * @param <T2> The type of field 2
+ * @param <T3> The type of field 3
+ * @param <T4> The type of field 4
+ */
@Public
public class Tuple5Builder<T0, T1, T2, T3, T4> {
http://git-wip-us.apache.org/repos/asf/flink/blob/36b2325a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple6Builder.java
----------------------------------------------------------------------
diff --git a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple6Builder.java b/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple6Builder.java
index 7eb6cc4..4ee0cd6 100644
--- a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple6Builder.java
+++ b/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple6Builder.java
@@ -16,21 +16,29 @@
* limitations under the License.
*/
-
// --------------------------------------------------------------
// THIS IS A GENERATED SOURCE FILE. DO NOT EDIT!
// GENERATED FROM org.apache.flink.api.java.tuple.TupleGenerator.
// --------------------------------------------------------------
-
package org.apache.flink.api.java.tuple.builder;
-import java.util.ArrayList;
-import java.util.List;
-
import org.apache.flink.annotation.Public;
import org.apache.flink.api.java.tuple.Tuple6;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * A builder class for {@link Tuple6}.
+ *
+ * @param <T0> The type of field 0
+ * @param <T1> The type of field 1
+ * @param <T2> The type of field 2
+ * @param <T3> The type of field 3
+ * @param <T4> The type of field 4
+ * @param <T5> The type of field 5
+ */
@Public
public class Tuple6Builder<T0, T1, T2, T3, T4, T5> {
http://git-wip-us.apache.org/repos/asf/flink/blob/36b2325a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple7Builder.java
----------------------------------------------------------------------
diff --git a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple7Builder.java b/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple7Builder.java
index 4157cf7..c8e3ebf 100644
--- a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple7Builder.java
+++ b/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple7Builder.java
@@ -16,21 +16,30 @@
* limitations under the License.
*/
-
// --------------------------------------------------------------
// THIS IS A GENERATED SOURCE FILE. DO NOT EDIT!
// GENERATED FROM org.apache.flink.api.java.tuple.TupleGenerator.
// --------------------------------------------------------------
-
package org.apache.flink.api.java.tuple.builder;
-import java.util.ArrayList;
-import java.util.List;
-
import org.apache.flink.annotation.Public;
import org.apache.flink.api.java.tuple.Tuple7;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * A builder class for {@link Tuple7}.
+ *
+ * @param <T0> The type of field 0
+ * @param <T1> The type of field 1
+ * @param <T2> The type of field 2
+ * @param <T3> The type of field 3
+ * @param <T4> The type of field 4
+ * @param <T5> The type of field 5
+ * @param <T6> The type of field 6
+ */
@Public
public class Tuple7Builder<T0, T1, T2, T3, T4, T5, T6> {
http://git-wip-us.apache.org/repos/asf/flink/blob/36b2325a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple8Builder.java
----------------------------------------------------------------------
diff --git a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple8Builder.java b/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple8Builder.java
index 6f7e87e..956e313 100644
--- a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple8Builder.java
+++ b/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple8Builder.java
@@ -16,21 +16,31 @@
* limitations under the License.
*/
-
// --------------------------------------------------------------
// THIS IS A GENERATED SOURCE FILE. DO NOT EDIT!
// GENERATED FROM org.apache.flink.api.java.tuple.TupleGenerator.
// --------------------------------------------------------------
-
package org.apache.flink.api.java.tuple.builder;
-import java.util.ArrayList;
-import java.util.List;
-
import org.apache.flink.annotation.Public;
import org.apache.flink.api.java.tuple.Tuple8;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * A builder class for {@link Tuple8}.
+ *
+ * @param <T0> The type of field 0
+ * @param <T1> The type of field 1
+ * @param <T2> The type of field 2
+ * @param <T3> The type of field 3
+ * @param <T4> The type of field 4
+ * @param <T5> The type of field 5
+ * @param <T6> The type of field 6
+ * @param <T7> The type of field 7
+ */
@Public
public class Tuple8Builder<T0, T1, T2, T3, T4, T5, T6, T7> {
http://git-wip-us.apache.org/repos/asf/flink/blob/36b2325a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple9Builder.java
----------------------------------------------------------------------
diff --git a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple9Builder.java b/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple9Builder.java
index c592a11..40a11c3 100644
--- a/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple9Builder.java
+++ b/flink-core/src/main/java/org/apache/flink/api/java/tuple/builder/Tuple9Builder.java
@@ -16,21 +16,32 @@
* limitations under the License.
*/
-
// --------------------------------------------------------------
// THIS IS A GENERATED SOURCE FILE. DO NOT EDIT!
// GENERATED FROM org.apache.flink.api.java.tuple.TupleGenerator.
// --------------------------------------------------------------
-
package org.apache.flink.api.java.tuple.builder;
-import java.util.ArrayList;
-import java.util.List;
-
import org.apache.flink.annotation.Public;
import org.apache.flink.api.java.tuple.Tuple9;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * A builder class for {@link Tuple9}.
+ *
+ * @param <T0> The type of field 0
+ * @param <T1> The type of field 1
+ * @param <T2> The type of field 2
+ * @param <T3> The type of field 3
+ * @param <T4> The type of field 4
+ * @param <T5> The type of field 5
+ * @param <T6> The type of field 6
+ * @param <T7> The type of field 7
+ * @param <T8> The type of field 8
+ */
@Public
public class Tuple9Builder<T0, T1, T2, T3, T4, T5, T6, T7, T8> {
http://git-wip-us.apache.org/repos/asf/flink/blob/36b2325a/flink-core/src/test/java/org/apache/flink/api/java/tuple/Tuple2Test.java
----------------------------------------------------------------------
diff --git a/flink-core/src/test/java/org/apache/flink/api/java/tuple/Tuple2Test.java b/flink-core/src/test/java/org/apache/flink/api/java/tuple/Tuple2Test.java
index b8fe14c..1096a25 100644
--- a/flink-core/src/test/java/org/apache/flink/api/java/tuple/Tuple2Test.java
+++ b/flink-core/src/test/java/org/apache/flink/api/java/tuple/Tuple2Test.java
@@ -19,9 +19,13 @@
package org.apache.flink.api.java.tuple;
import org.apache.flink.types.NullFieldException;
+
import org.junit.Assert;
import org.junit.Test;
+/**
+ * Tests for {@link Tuple2}.
+ */
public class Tuple2Test {
@Test
@@ -33,7 +37,7 @@ public class Tuple2Test {
Assert.assertEquals(swapped.f1, toSwap.f0);
}
-
+
@Test(expected = NullFieldException.class)
public void testGetFieldNotNull() {
Tuple2<String, Integer> tuple = new Tuple2<>("Test case", null);
http://git-wip-us.apache.org/repos/asf/flink/blob/36b2325a/flink-core/src/test/java/org/apache/flink/api/java/tuple/TupleGenerator.java
----------------------------------------------------------------------
diff --git a/flink-core/src/test/java/org/apache/flink/api/java/tuple/TupleGenerator.java b/flink-core/src/test/java/org/apache/flink/api/java/tuple/TupleGenerator.java
index 33973f1..bd5598a 100644
--- a/flink-core/src/test/java/org/apache/flink/api/java/tuple/TupleGenerator.java
+++ b/flink-core/src/test/java/org/apache/flink/api/java/tuple/TupleGenerator.java
@@ -58,14 +58,13 @@ class TupleGenerator {
private static final int LAST = 25;
-
public static void main(String[] args) throws Exception {
- System.err.println("Current directory "+System.getProperty("user.dir"));
+ System.err.println("Current directory " + System.getProperty("user.dir"));
String rootDir = ROOT_DIRECTORY;
- if(args.length > 0) {
+ if (args.length > 0) {
rootDir = args[0] + "/" + ROOT_DIRECTORY;
}
- System.err.println("Using root directory: "+rootDir);
+ System.err.println("Using root directory: " + rootDir);
File root = new File(rootDir);
createTupleClasses(root);
@@ -87,13 +86,13 @@ class TupleGenerator {
private static void insertCodeIntoFile(String code, File file) throws IOException {
String fileContent = FileUtils.readFileUtf8(file);
-
+
try (Scanner s = new Scanner(fileContent)) {
StringBuilder sb = new StringBuilder();
String line;
-
+
boolean indicatorFound = false;
-
+
// add file beginning
while (s.hasNextLine() && (line = s.nextLine()) != null) {
sb.append(line).append("\n");
@@ -102,19 +101,19 @@ class TupleGenerator {
break;
}
}
-
- if(!indicatorFound) {
+
+ if (!indicatorFound) {
System.out.println("No indicator found in '" + file + "'. Will skip code generation.");
s.close();
return;
}
-
+
// add generator signature
sb.append("\t// GENERATED FROM ").append(TupleGenerator.class.getName()).append(".\n");
-
+
// add tuple dependent code
sb.append(code).append("\n");
-
+
// skip generated code
while (s.hasNextLine() && (line = s.nextLine()) != null) {
if (line.contains(END_INDICATOR)) {
@@ -122,7 +121,7 @@ class TupleGenerator {
break;
}
}
-
+
// add file ending
while (s.hasNextLine() && (line = s.nextLine()) != null) {
sb.append(line).append("\n");
@@ -131,7 +130,6 @@ class TupleGenerator {
}
}
-
private static void modifyTupleType(File root) throws IOException {
// generate code
StringBuilder sb = new StringBuilder();
@@ -244,10 +242,11 @@ class TupleGenerator {
w.println("\t}");
w.println();
-
// arity accessor
w.println("\t@Override");
- w.println("\tpublic int getArity() { return " + numFields + "; }");
+ w.println("\tpublic int getArity() {");
+ w.println("\t\treturn " + numFields + ";");
+ w.println("\t}");
w.println();
// accessor getter method
@@ -332,20 +331,26 @@ class TupleGenerator {
w.println();
w.println("\t/**");
- w.println("\t * Deep equality for tuples by calling equals() on the tuple members");
+ w.println("\t * Deep equality for tuples by calling equals() on the tuple members.");
w.println("\t * @param o the object checked for equality");
w.println("\t * @return true if this is equal to o.");
w.println("\t */");
w.println("\t@Override");
w.println("\tpublic boolean equals(Object o) {");
- w.println("\t\tif(this == o) { return true; }");
- w.println("\t\tif (!(o instanceof " + className + ")) { return false; }");
+ w.println("\t\tif (this == o) {");
+ w.println("\t\t\treturn true;");
+ w.println("\t\t}");
+ w.println("\t\tif (!(o instanceof " + className + ")) {");
+ w.println("\t\t\treturn false;");
+ w.println("\t\t}");
w.println("\t\t@SuppressWarnings(\"rawtypes\")");
w.println("\t\t" + className + " tuple = (" + className + ") o;");
for (int i = 0; i < numFields; i++) {
String field = "f" + i;
- w.println("\t\tif (" + field + " != null ? !" + field +".equals(tuple." +
- field + ") : tuple." + field + " != null) { return false; }");
+ w.println("\t\tif (" + field + " != null ? !" + field + ".equals(tuple." +
+ field + ") : tuple." + field + " != null) {");
+ w.println("\t\t\treturn false;");
+ w.println("\t\t}");
}
w.println("\t\treturn true;");
w.println("\t}");
@@ -361,15 +366,13 @@ class TupleGenerator {
w.println("\t\treturn result;");
w.println("\t}");
-
- String tupleTypes = "<";
+ String tupleTypes = "";
for (int i = 0; i < numFields; i++) {
tupleTypes += "T" + i;
if (i < numFields - 1) {
- tupleTypes += ",";
+ tupleTypes += ", ";
}
}
- tupleTypes += ">";
w.println();
w.println("\t/**");
@@ -378,9 +381,9 @@ class TupleGenerator {
w.println("\t*/");
w.println("\t@Override");
w.println("\t@SuppressWarnings(\"unchecked\")");
- w.println("\tpublic " + className + tupleTypes + " copy(){ ");
+ w.println("\tpublic " + className + "<" + tupleTypes + "> copy() {");
- w.print("\t\treturn new " + className + tupleTypes + "(this.f0");
+ w.print("\t\treturn new " + className + "<>(this.f0");
if (numFields > 1) {
w.println(",");
}
@@ -403,12 +406,16 @@ class TupleGenerator {
w.println("\t * instead of");
w.println("\t * {@code new Tuple3<Integer, Double, String>(n, x, s)}");
w.println("\t */");
- w.println("\tpublic static " + tupleTypes + " " + className + tupleTypes + " of" + paramList + " {");
- w.print("\t\treturn new " + className + tupleTypes + "(");
- for(int i = 0; i < numFields; i++) {
- w.print("value" + i);
- if(i < numFields - 1) {
- w.print(", ");
+ w.println("\tpublic static <" + tupleTypes + "> " + className + "<" + tupleTypes + "> of" + paramList + " {");
+
+ w.print("\t\treturn new " + className + "<>(value0");
+ if (numFields > 1) {
+ w.println(",");
+ }
+ for (int i = 1; i < numFields; i++) {
+ w.print("\t\t\tvalue" + i);
+ if (i < numFields - 1) {
+ w.println(",");
}
}
w.println(");");
@@ -419,7 +426,7 @@ class TupleGenerator {
}
private static void createTupleBuilderClasses(File root) throws FileNotFoundException {
- File dir = getPackage(root, PACKAGE+"."+BUILDER_SUFFIX);
+ File dir = getPackage(root, PACKAGE + "." + BUILDER_SUFFIX);
for (int i = FIRST; i <= LAST; i++) {
File tupleFile = new File(dir, "Tuple" + i + "Builder.java");
@@ -450,12 +457,21 @@ class TupleGenerator {
// package and imports
w.println("package " + PACKAGE + "." + BUILDER_SUFFIX + ';');
w.println();
- w.println("import java.util.ArrayList;");
- w.println("import java.util.List;");
- w.println();
w.println("import org.apache.flink.annotation.Public;");
w.println("import " + PACKAGE + ".Tuple" + numFields + ";");
w.println();
+ w.println("import java.util.ArrayList;");
+ w.println("import java.util.List;");
+ w.println();
+
+ // class javadoc
+ w.println("/**");
+ w.println(" * A builder class for {@link Tuple" + numFields + "}.");
+ w.println(" *");
+ for (int i = 0; i < numFields; i++) {
+ w.println(" * @param <" + GEN_TYPE_PREFIX + i + "> The type of field " + i);
+ }
+ w.println(" */");
// class declaration
w.println("@Public");
@@ -505,7 +521,7 @@ class TupleGenerator {
w.println("}");
}
- private static String HEADER =
+ private static final String HEADER =
"/*\n"
+ " * Licensed to the Apache Software Foundation (ASF) under one\n"
+ " * or more contributor license agreements. See the NOTICE file\n"
@@ -525,9 +541,8 @@ class TupleGenerator {
+ " */" +
"\n" +
"\n" +
- "\n" +
"// --------------------------------------------------------------\n" +
"// THIS IS A GENERATED SOURCE FILE. DO NOT EDIT!\n" +
"// GENERATED FROM " + TupleGenerator.class.getName() + ".\n" +
- "// --------------------------------------------------------------\n\n\n";
+ "// --------------------------------------------------------------\n\n";
}
http://git-wip-us.apache.org/repos/asf/flink/blob/36b2325a/tools/maven/suppressions-core.xml
----------------------------------------------------------------------
diff --git a/tools/maven/suppressions-core.xml b/tools/maven/suppressions-core.xml
index 7b0ccc7..e613fb0 100644
--- a/tools/maven/suppressions-core.xml
+++ b/tools/maven/suppressions-core.xml
@@ -28,10 +28,6 @@ under the License.
checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
<suppress
- files="(.*)api[/\\]java[/\\]tuple[/\\](.*)"
- checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
-
- <suppress
files="(.*)api[/\\]java[/\\]typeutils[/\\]runtime[/\\](.*)"
checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
<!--Only additional checks for test sources. Those checks were present in the "pre-strict" checkstyle but were not applied to test sources. We do not want to suppress them for sources directory-->