[jira] [Commented] (FLINK-8660) Enable the user to provide custom HAServices implementation

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392908#comment-16392908 ] 

ASF GitHub Bot commented on FLINK-8660:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5530
  
    I think this looks quite good now.
    
    Since 1.5 feature freeze is over for a bit, would suggest to merge this into master (1.6-SNAPSHOT).
    
    Looking at the code (this PR and the high availability configuration in general), I would suggest to work towards the following design in the future:
    
      - We don't have specific high availability enums and setting, everything is just an implementation of HAServices. Some HAServices are in fact not highly available (maybe we need to find a better name for HAServices).
      - There are factories for all HAServices
      - We simply have "none" and "zookeeper" as aliases for the respective factories.
    
    That mirrors the design of he state backends and their configuration, which is nice, because we never need to do special checks like "isHighAvailabilityEnabled".


> Enable the user to provide custom HAServices implementation 
> ------------------------------------------------------------
>
>                 Key: FLINK-8660
>                 URL: https://issues.apache.org/jira/browse/FLINK-8660
>             Project: Flink
>          Issue Type: Improvement
>          Components: Cluster Management, Configuration, Distributed Coordination
>    Affects Versions: 1.4.0, 1.5.0
>            Reporter: Krzysztof Białek
>            Priority: Major
>             Fix For: 1.6.0
>
>
> At the moment Flink uses ZooKeeper as HA backend.
> The goal of this improvement is to make Flink supporting more HA backends, also maintained as independent projects.
> The following changes are required to achieve it:
>  # Add {{HighAvailabilityServicesFactory}} interface
>  # Add new option {{HighAvailabilityMode.CUSTOM}}
>  # Add new configuration property {{high-availability.factoryClass}}
>  # Use the factory in {{HighAvailabilityServicesUtils}} to instantiate  {{HighAvailabilityServices}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)