You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/10 02:46:28 UTC

[GitHub] [arrow-rs] viirya commented on a diff in pull request #3071: Deprecate Buffer::count_set_bits (#3067)

viirya commented on code in PR #3071:
URL: https://github.com/apache/arrow-rs/pull/3071#discussion_r1018601156


##########
arrow-select/src/filter.rs:
##########
@@ -413,7 +413,7 @@ fn filter_null_mask(
     let nulls = filter_bits(data.null_buffer()?, data.offset(), predicate);
     // The filtered `nulls` has a length of `predicate.count` bits and
     // therefore the null count is this minus the number of valid bits
-    let null_count = predicate.count - nulls.count_set_bits();
+    let null_count = predicate.count - nulls.count_set_bits_offset(0, predicate.count);

Review Comment:
   👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org