You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jonathan Gray (JIRA)" <ji...@apache.org> on 2010/06/19 18:17:23 UTC
[jira] Created: (HBASE-2753) Remove sorted() methods from Result
now that Gets are Scans
Remove sorted() methods from Result now that Gets are Scans
-----------------------------------------------------------
Key: HBASE-2753
URL: https://issues.apache.org/jira/browse/HBASE-2753
Project: HBase
Issue Type: Improvement
Components: client
Affects Versions: 0.21.0
Reporter: Jonathan Gray
Fix For: 0.21.0
With the old Get codepath, we used to sometimes get results sent to the client that weren't fully sorted. Now that Gets are Scans, results should always be sorted.
Confirm that we always get back sorted results and if so drop the Result.sorted() method and update javadoc accordingly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-2753) Remove sorted() methods from Result
now that Gets are Scans
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ryan rawson resolved HBASE-2753.
--------------------------------
Resolution: Fixed
this is committed, we no longer sort in Result.
> Remove sorted() methods from Result now that Gets are Scans
> -----------------------------------------------------------
>
> Key: HBASE-2753
> URL: https://issues.apache.org/jira/browse/HBASE-2753
> Project: HBase
> Issue Type: Improvement
> Components: client
> Affects Versions: 0.90.0
> Reporter: Jonathan Gray
> Assignee: ryan rawson
> Fix For: 0.90.0
>
>
> With the old Get codepath, we used to sometimes get results sent to the client that weren't fully sorted. Now that Gets are Scans, results should always be sorted.
> Confirm that we always get back sorted results and if so drop the Result.sorted() method and update javadoc accordingly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HBASE-2753) Remove sorted() methods from Result
now that Gets are Scans
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack reassigned HBASE-2753:
----------------------------
Assignee: ryan rawson
> Remove sorted() methods from Result now that Gets are Scans
> -----------------------------------------------------------
>
> Key: HBASE-2753
> URL: https://issues.apache.org/jira/browse/HBASE-2753
> Project: HBase
> Issue Type: Improvement
> Components: client
> Affects Versions: 0.90.0
> Reporter: Jonathan Gray
> Assignee: ryan rawson
> Fix For: 0.90.0
>
>
> With the old Get codepath, we used to sometimes get results sent to the client that weren't fully sorted. Now that Gets are Scans, results should always be sorted.
> Confirm that we always get back sorted results and if so drop the Result.sorted() method and update javadoc accordingly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2753) Remove sorted() methods from Result
now that Gets are Scans
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880509#action_12880509 ]
Todd Lipcon commented on HBASE-2753:
------------------------------------
maybe as an interim we can add: assert Ordering.from(new KVComparator()).isOrdered(result) to the function, and then if we don't see any hudson failures for a week, take out the sort call?
> Remove sorted() methods from Result now that Gets are Scans
> -----------------------------------------------------------
>
> Key: HBASE-2753
> URL: https://issues.apache.org/jira/browse/HBASE-2753
> Project: HBase
> Issue Type: Improvement
> Components: client
> Affects Versions: 0.21.0
> Reporter: Jonathan Gray
> Fix For: 0.21.0
>
>
> With the old Get codepath, we used to sometimes get results sent to the client that weren't fully sorted. Now that Gets are Scans, results should always be sorted.
> Confirm that we always get back sorted results and if so drop the Result.sorted() method and update javadoc accordingly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2753) Remove sorted() methods from Result
now that Gets are Scans
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922431#action_12922431 ]
stack commented on HBASE-2753:
------------------------------
Yeah... a few days ago I enabled assertions when tests run. We should try enabling assertions when we run too.. but yeah, this is looking like its fixed in 0.90... just make it last thing we close out.
> Remove sorted() methods from Result now that Gets are Scans
> -----------------------------------------------------------
>
> Key: HBASE-2753
> URL: https://issues.apache.org/jira/browse/HBASE-2753
> Project: HBase
> Issue Type: Improvement
> Components: client
> Affects Versions: 0.90.0
> Reporter: Jonathan Gray
> Assignee: ryan rawson
> Fix For: 0.90.0
>
>
> With the old Get codepath, we used to sometimes get results sent to the client that weren't fully sorted. Now that Gets are Scans, results should always be sorted.
> Confirm that we always get back sorted results and if so drop the Result.sorted() method and update javadoc accordingly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2753) Remove sorted() methods from Result
now that Gets are Scans
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921646#action_12921646 ]
stack commented on HBASE-2753:
------------------------------
I enabled asserts when we run tests a few days ago.
> Remove sorted() methods from Result now that Gets are Scans
> -----------------------------------------------------------
>
> Key: HBASE-2753
> URL: https://issues.apache.org/jira/browse/HBASE-2753
> Project: HBase
> Issue Type: Improvement
> Components: client
> Affects Versions: 0.90.0
> Reporter: Jonathan Gray
> Assignee: ryan rawson
> Fix For: 0.90.0
>
>
> With the old Get codepath, we used to sometimes get results sent to the client that weren't fully sorted. Now that Gets are Scans, results should always be sorted.
> Confirm that we always get back sorted results and if so drop the Result.sorted() method and update javadoc accordingly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2753) Remove sorted() methods from Result
now that Gets are Scans
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918292#action_12918292 ]
Jonathan Gray commented on HBASE-2753:
--------------------------------------
We'll need to deprecate for 0.90 and remove in 0.92.
> Remove sorted() methods from Result now that Gets are Scans
> -----------------------------------------------------------
>
> Key: HBASE-2753
> URL: https://issues.apache.org/jira/browse/HBASE-2753
> Project: HBase
> Issue Type: Improvement
> Components: client
> Affects Versions: 0.90.0
> Reporter: Jonathan Gray
> Assignee: ryan rawson
> Fix For: 0.90.0
>
>
> With the old Get codepath, we used to sometimes get results sent to the client that weren't fully sorted. Now that Gets are Scans, results should always be sorted.
> Confirm that we always get back sorted results and if so drop the Result.sorted() method and update javadoc accordingly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2753) Remove sorted() methods from Result
now that Gets are Scans
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924762#action_12924762 ]
HBase Review Board commented on HBASE-2753:
-------------------------------------------
Message from: "Jonathan Gray" <jg...@apache.org>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1092/#review1661
-----------------------------------------------------------
Ship it!
looks good to me
- Jonathan
> Remove sorted() methods from Result now that Gets are Scans
> -----------------------------------------------------------
>
> Key: HBASE-2753
> URL: https://issues.apache.org/jira/browse/HBASE-2753
> Project: HBase
> Issue Type: Improvement
> Components: client
> Affects Versions: 0.90.0
> Reporter: Jonathan Gray
> Assignee: ryan rawson
> Fix For: 0.90.0
>
>
> With the old Get codepath, we used to sometimes get results sent to the client that weren't fully sorted. Now that Gets are Scans, results should always be sorted.
> Confirm that we always get back sorted results and if so drop the Result.sorted() method and update javadoc accordingly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2753) Remove sorted() methods from Result
now that Gets are Scans
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917121#action_12917121 ]
ryan rawson commented on HBASE-2753:
------------------------------------
commited the assert
> Remove sorted() methods from Result now that Gets are Scans
> -----------------------------------------------------------
>
> Key: HBASE-2753
> URL: https://issues.apache.org/jira/browse/HBASE-2753
> Project: HBase
> Issue Type: Improvement
> Components: client
> Affects Versions: 0.90.0
> Reporter: Jonathan Gray
> Assignee: ryan rawson
> Fix For: 0.90.0
>
>
> With the old Get codepath, we used to sometimes get results sent to the client that weren't fully sorted. Now that Gets are Scans, results should always be sorted.
> Confirm that we always get back sorted results and if so drop the Result.sorted() method and update javadoc accordingly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2753) Remove sorted() methods from Result
now that Gets are Scans
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880523#action_12880523 ]
stack commented on HBASE-2753:
------------------------------
I like the idea of adding an assert for a while.
> Remove sorted() methods from Result now that Gets are Scans
> -----------------------------------------------------------
>
> Key: HBASE-2753
> URL: https://issues.apache.org/jira/browse/HBASE-2753
> Project: HBase
> Issue Type: Improvement
> Components: client
> Affects Versions: 0.21.0
> Reporter: Jonathan Gray
> Fix For: 0.21.0
>
>
> With the old Get codepath, we used to sometimes get results sent to the client that weren't fully sorted. Now that Gets are Scans, results should always be sorted.
> Confirm that we always get back sorted results and if so drop the Result.sorted() method and update javadoc accordingly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2753) Remove sorted() methods from Result
now that Gets are Scans
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924759#action_12924759 ]
HBase Review Board commented on HBASE-2753:
-------------------------------------------
Message from: "Ryan Rawson" <ry...@gmail.com>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1092/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
the last hurrah, removing the sorting from Result. sorted() is already @deprecated
This addresses bug HBASE-2753.
http://issues.apache.org/jira/browse/HBASE-2753
Diffs
-----
trunk/src/main/java/org/apache/hadoop/hbase/client/Result.java 1026537
Diff: http://review.cloudera.org/r/1092/diff
Testing
-------
Thanks,
Ryan
> Remove sorted() methods from Result now that Gets are Scans
> -----------------------------------------------------------
>
> Key: HBASE-2753
> URL: https://issues.apache.org/jira/browse/HBASE-2753
> Project: HBase
> Issue Type: Improvement
> Components: client
> Affects Versions: 0.90.0
> Reporter: Jonathan Gray
> Assignee: ryan rawson
> Fix For: 0.90.0
>
>
> With the old Get codepath, we used to sometimes get results sent to the client that weren't fully sorted. Now that Gets are Scans, results should always be sorted.
> Confirm that we always get back sorted results and if so drop the Result.sorted() method and update javadoc accordingly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2753) Remove sorted() methods from Result
now that Gets are Scans
Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922387#action_12922387 ]
ryan rawson commented on HBASE-2753:
------------------------------------
its not done until it's done, and the sort is still in the code base. Lets wait until later this week for some more test runs.
> Remove sorted() methods from Result now that Gets are Scans
> -----------------------------------------------------------
>
> Key: HBASE-2753
> URL: https://issues.apache.org/jira/browse/HBASE-2753
> Project: HBase
> Issue Type: Improvement
> Components: client
> Affects Versions: 0.90.0
> Reporter: Jonathan Gray
> Assignee: ryan rawson
> Fix For: 0.90.0
>
>
> With the old Get codepath, we used to sometimes get results sent to the client that weren't fully sorted. Now that Gets are Scans, results should always be sorted.
> Confirm that we always get back sorted results and if so drop the Result.sorted() method and update javadoc accordingly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2753) Remove sorted() methods from Result
now that Gets are Scans
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922384#action_12922384 ]
Jonathan Gray commented on HBASE-2753:
--------------------------------------
Should we move this to 0.92 now? sorted() is already deprecated on trunk as of now.
> Remove sorted() methods from Result now that Gets are Scans
> -----------------------------------------------------------
>
> Key: HBASE-2753
> URL: https://issues.apache.org/jira/browse/HBASE-2753
> Project: HBase
> Issue Type: Improvement
> Components: client
> Affects Versions: 0.90.0
> Reporter: Jonathan Gray
> Assignee: ryan rawson
> Fix For: 0.90.0
>
>
> With the old Get codepath, we used to sometimes get results sent to the client that weren't fully sorted. Now that Gets are Scans, results should always be sorted.
> Confirm that we always get back sorted results and if so drop the Result.sorted() method and update javadoc accordingly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2753) Remove sorted() methods from Result
now that Gets are Scans
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918287#action_12918287 ]
stack commented on HBASE-2753:
------------------------------
We'll remove before we RC.
> Remove sorted() methods from Result now that Gets are Scans
> -----------------------------------------------------------
>
> Key: HBASE-2753
> URL: https://issues.apache.org/jira/browse/HBASE-2753
> Project: HBase
> Issue Type: Improvement
> Components: client
> Affects Versions: 0.90.0
> Reporter: Jonathan Gray
> Assignee: ryan rawson
> Fix For: 0.90.0
>
>
> With the old Get codepath, we used to sometimes get results sent to the client that weren't fully sorted. Now that Gets are Scans, results should always be sorted.
> Confirm that we always get back sorted results and if so drop the Result.sorted() method and update javadoc accordingly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.